Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: fix CQ after latest ncu release #35468

Closed
wants to merge 1 commit into from

Conversation

mmarchini
Copy link
Contributor

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the meta Issues and PRs related to the general management of the project. label Oct 2, 2020
@mmarchini
Copy link
Contributor Author

Fast track?

@mmarchini mmarchini added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 2, 2020
The new behavior of node-core-utils (which fetches the merge commit
instead of fetching the patch files) requires the whole repo to be
cloned, instead of just the last commit.
@mmarchini
Copy link
Contributor Author

Landed in 919be91

@mmarchini mmarchini closed this Oct 2, 2020
mmarchini added a commit that referenced this pull request Oct 2, 2020
The new behavior of node-core-utils (which fetches the merge commit
instead of fetching the patch files) requires the whole repo to be
cloned, instead of just the last commit.

PR-URL: #35468
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
danielleadams pushed a commit that referenced this pull request Oct 6, 2020
The new behavior of node-core-utils (which fetches the merge commit
instead of fetching the patch files) requires the whole repo to be
cloned, instead of just the last commit.

PR-URL: #35468
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
@danielleadams danielleadams mentioned this pull request Oct 6, 2020
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
The new behavior of node-core-utils (which fetches the merge commit
instead of fetching the patch files) requires the whole repo to be
cloned, instead of just the last commit.

PR-URL: nodejs#35468
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Beth Griggs <Bethany.Griggs@uk.ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
fast-track PRs that do not need to wait for 48 hours to land. meta Issues and PRs related to the general management of the project.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants