lib: add EventTarget-related browser globals #35496

addaleax · 2020-10-04T12:35:53Z

worker: make MessageEvent class more Web-compatible

lib: add EventTarget-related browser globals

Add

Event
EventTarget
MessagePort
MessageChannel
MessageEvent

to the set of global objects, since they are available now and behave
like they do in the browser.

Fixes: #35495

Checklist

make -j4 test (UNIX), or vcbuild test (Windows) passes
tests and/or benchmarks are included
documentation is changed or added
commit message follows commit guidelines

Add - Event - EventTarget - MessagePort - MessageChannel - MessageEvent to the set of global objects, since they are available now and behave like they do in the browser. Fixes: nodejs#35495

nodejs-github-bot · 2020-10-04T12:35:57Z

Review requested:

@nodejs/startup

addaleax · 2020-10-04T12:36:09Z

@nodejs/tsc As mentioned in the issue, it might be nice to get this into Node v15.0.0.

nodejs-github-bot · 2020-10-04T12:37:02Z

CI: https://ci.nodejs.org/job/node-test-pull-request/33377/
CITGM: https://ci.nodejs.org/view/Node.js-citgm/job/citgm-smoker/2491/

MylesBorins

LGTM

mhdawson

LGTM

BridgeAR · 2020-10-08T21:23:31Z

Adding these globals are going to add 13 modules to the bootstrap part. Did we measure the startup time with these? I guess it'll slow down startup quite a bit?

BridgeAR · 2020-10-08T21:24:47Z

Would it be sufficient to add the globals in a way that they only actually load the modules when accessed?

addaleax · 2020-10-08T21:31:24Z

@BridgeAR These are part of the startup snapshot, i.e. loading them early is good for runtime performance, not bad.

nodejs-github-bot · 2020-10-08T21:42:27Z

CI: https://ci.nodejs.org/job/node-test-pull-request/33480/

BridgeAR · 2020-10-09T09:12:26Z

Seems like there's a 3% performance drop when loading these globals in some cases: https://ci.nodejs.org/view/Node.js%20benchmark/job/benchmark-node-micro-benchmarks/666/console

nodejs-github-bot · 2020-10-09T09:46:19Z

CI: https://ci.nodejs.org/job/node-test-pull-request/33485/

XadillaX

LGTM if CI is OK

github-actions · 2020-10-11T14:35:21Z

Landed in 828518c...eee522a

PR-URL: #35496 Fixes: #35495 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Khaidi Chu <i@2333.moe>

Add - Event - EventTarget - MessagePort - MessageChannel - MessageEvent to the set of global objects, since they are available now and behave like they do in the browser. Fixes: #35495 PR-URL: #35496 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Khaidi Chu <i@2333.moe>

Notable changes: Deprecations and Removals: - **build**: remove --build-v8-with-gn configure option (Yang Guo) (#27576) - **build**: drop support for VS2017 (Michaël Zasso) (#33694) - **doc**: move DEP0018 to End-of-Life (Rich Trott) (#35316) - **fs**: deprecation warning on recursive rmdir (Ian Sutherland) (#35562) - **lib**: add EventTarget-related browser globals (Anna Henningsen) (#35496) - **net**: remove long deprecated server.connections property (James M Snell) (#33647) - **repl**: remove deprecated repl.memory function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.turnOffEditorMode() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.parseREPLKeyword() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated bufferedCommand property (Ruben Bridgewater) (#33286) - **repl**: remove deprecated .rli (Ruben Bridgewater) (#33286) - **src**: remove deprecated node debug command (James M Snell) (#33648) - **timers**: introduce timers/promises (James M Snell) (#33950) - **util**: change default value of `maxStringLength` to 10000 (unknown) (#32744) - **wasi**: drop --experimental-wasm-bigint requirement (Colin Ihrig) (#35415) npm 7 (#35631): Node.js 15 comes with a new major release of npm, npm 7. npm 7 comes with many new features - including npm workspaces and a new package-lock.json format. npm 7 also includes yarn.lock file support. One of the big changes in npm 7 is that peer dependencies are now installed by default. Throw On Unhandled Rejections (#33021): As of Node.js 15, the default mode for `unhandledRejection` is changed to `throw` (from `warn`). In `throw` mode, if an `unhandledRejection` hook is not set, the `unhandledRejection` is raised as an uncaught exception. Users that have an `unhandledRejection` hook should see no change in behavior, and it’s still possible to switch modes using the `--unhandled-rejections=mode` process flag. QUIC (#32379): Node.js 15 comes with experimental support QUIC, which can be enabled by compiling Node.js with the `--experimental-quic` configuration flag. The Node.js QUIC implementation is exposed by the core `net` module. V8 8.6 (#35415): The V8 JavaScript engine has been updated to V8 8.6 (V8 8.4 is the latest available in Node.js 14). Along with performance tweaks and improvements the V8 update also brings the following language features: * `Promise.any()` (from V8 8.5) * `AggregateError` (from V8 8.5) * `String.prototype.replaceAll()` (from V8 8.5) * Logical assignment operators `&&=`, `||=`, and `??=` (from V8 8.5) Other Notable Changes: - **assert**: add `assert/strict` alias module (ExE Boss) (#34001) - **dns**: add dns/promises alias (shisama) (#32953) - **fs**: reimplement read and write streams using stream.construct (Robert Nagy) (#29656) - **http2**: allow Host in HTTP/2 requests (Alba Mendez) (#34664) - **lib**: add EventTarget-related browser globals (Anna Henningsen) (#35496) - **lib**: unflag AbortController (James M Snell) (#33527) - **lib**: initial experimental AbortController implementation (James M Snell) (#33527) - **net**: autoDestroy Socket (Robert Nagy) (#31806) - **src**: disallow JS execution inside FreeEnvironment (Anna Henningsen) (#33874) - **stream**: construct (Robert Nagy) (#29656) - **worker**: make MessageEvent class more Web-compatible (Anna Henningsen) (#35496) Semver-Major Commits: - **assert**: add `assert/strict` alias module (ExE Boss) (#34001) - **build**: reset embedder string to "-node.0" (Michaël Zasso) (#35415) - **build**: remove --build-v8-with-gn configure option (Yang Guo) (#27576) - **build**: drop support for VS2017 (Michaël Zasso) (#33694) - **crypto**: refactoring internals, add WebCrypto (James M Snell) (#35093) - **crypto**: move node\_crypto files to src/crypto (James M Snell) (#35093) - **deps**: V8: cherry-pick d76abfed3512 (Michaël Zasso) (#35415) - **deps**: V8: cherry-pick 717543bbf0ef (Michaël Zasso) (#35415) - **deps**: V8: cherry-pick 6be2f6e26e8d (Michaël Zasso) (#35415) - **deps**: fix V8 build issue with inline methods (Jiawen Geng) (#35415) - **deps**: fix platform-embedded-file-writer-win for ARM64 (Michaël Zasso) (#35415) - **deps**: update V8 postmortem metadata script (Colin Ihrig) (#35415) - **deps**: update V8 to 8.6.395 (Michaël Zasso) (#35415) - **deps**: upgrade npm to 7.0.0 (Myles Borins) (#35631) - **deps**: update npm to 7.0.0-rc.3 (Myles Borins) (#35474) - **deps**: V8: cherry-pick 0d6debcc5f08 (Gus Caplan) (#33600) - **dns**: add dns/promises alias (shisama) (#32953) - **doc**: move DEP0018 to End-of-Life (Rich Trott) (#35316) - **doc**: update support macos version for 15.x (Ash Cripps) (#35022) - **fs**: deprecation warning on recursive rmdir (Ian Sutherland) (#35562) - **fs**: reimplement read and write streams using stream.construct (Robert Nagy) (#29656) - **http**: fixed socket.setEncoding fatal error (iskore) (#33405) - **http**: emit 'error' on aborted server request (Robert Nagy) (#33172) - **http**: cleanup end argument handling (Robert Nagy) (#31818) - **http2**: allow Host in HTTP/2 requests (Alba Mendez) (#34664) - **http2**: add `invalidheaders` test (Pranshu Srivastava) (#33161) - **http2**: refactor state code validation for the http2Stream class (rickyes) (#33535) - **http2**: header field valid checks (Pranshu Srivastava) (#33193) - **lib**: add EventTarget-related browser globals (Anna Henningsen) (#35496) - **lib**: remove ERR\_INVALID\_OPT\_VALUE and ERR\_INVALID\_OPT\_VALUE\_ENCODING (Denys Otrishko) (#34682) - **lib**: handle one of args case in ERR\_MISSING\_ARGS (Denys Otrishko) (#34022) - **lib**: remove NodeError from the prototype of errors with code (Michaël Zasso) (#33857) - **lib**: unflag AbortController (James M Snell) (#33527) - **lib**: initial experimental AbortController implementation (James M Snell) (#33527) - **net**: check args in net.connect() and socket.connect() calls (Denys Otrishko) (#34022) - **net**: remove long deprecated server.connections property (James M Snell) (#33647) - **net**: autoDestroy Socket (Robert Nagy) (#31806) - **process**: update v8 fast api calls usage (Maya Lekova) (#35415) - **process**: change default --unhandled-rejections=throw (Dan Fabulich) (#33021) - **process**: use v8 fast api calls for hrtime (Gus Caplan) (#33600) - **process**: delay throwing an error using `throwDeprecation` (Ruben Bridgewater) (#32312) - **repl**: remove deprecated repl.memory function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.turnOffEditorMode() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated repl.parseREPLKeyword() function (Ruben Bridgewater) (#33286) - **repl**: remove deprecated bufferedCommand property (Ruben Bridgewater) (#33286) - **repl**: remove deprecated .rli (Ruben Bridgewater) (#33286) - **src**: implement NodePlatform::PostJob (Clemens Backes) (#35415) - **src**: update NODE\_MODULE\_VERSION to 88 (Michaël Zasso) (#35415) - **src**: error reporting on CPUUsage (Yash Ladha) (#34762) - **src**: use node:moduleName as builtin module filename (Michaël Zasso) (#35498) - **src**: enable wasm trap handler on windows (Gus Caplan) (#35033) - **src**: update NODE\_MODULE\_VERSION to 86 (Michaël Zasso) (#33579) - **src**: disallow JS execution inside FreeEnvironment (Anna Henningsen) (#33874) - **src**: remove \_third\_party\_main support (Anna Henningsen) (#33971) - **src**: remove deprecated node debug command (James M Snell) (#33648) - **src**: remove unused CancelPendingDelayedTasks (Anna Henningsen) (#32859) - **stream**: try to wait for flush to complete before 'finish' (Robert Nagy) (#34314) - **stream**: cleanup and fix Readable.wrap (Robert Nagy) (#34204) - **stream**: add promises version to utility functions (rickyes) (#33991) - **stream**: fix writable.end callback behavior (Robert Nagy) (#34101) - **stream**: construct (Robert Nagy) (#29656) - **stream**: write should throw on unknown encoding (Robert Nagy) (#33075) - **stream**: fix \_final and 'prefinish' timing (Robert Nagy) (#32780) - **stream**: simplify Transform stream implementation (Robert Nagy) (#32763) - **stream**: use callback to properly propagate error (Robert Nagy) (#29179) - **test**: update tests after increasing typed array size to 4GB (Kim-Anh Tran) (#35415) - **test**: fix tests for npm 7.0.0 (Myles Borins) (#35631) - **test**: fix test suite to work with npm 7 (Myles Borins) (#35474) - **test**: update WPT harness and tests (Michaël Zasso) (#33770) - **timers**: introduce timers/promises (James M Snell) (#33950) - **tools**: disable x86 safe exception handlers in V8 (Michaël Zasso) (#35415) - **tools**: update V8 gypfiles for 8.6 (Ujjwal Sharma) (#35415) - **tools**: update V8 gypfiles for 8.5 (Ujjwal Sharma) (#35415) - **url**: file URL path normalization (Daijiro Wachi) (#35477) - **url**: verify domain is not empty after "ToASCII" (Michaël Zasso) (#33770) - **url**: remove U+0000 case in the fragment state (Michaël Zasso) (#33770) - **url**: remove gopher from special schemes (Michaël Zasso) (#33325) - **url**: forbid lt and gt in url host code point (Yash Ladha) (#33328) - **util**: change default value of `maxStringLength` to 10000 (unknown) (#32744) - **wasi**: drop --experimental-wasm-bigint requirement (Colin Ihrig) (#35415) - **win, child_process**: sanitize env variables (Bartosz Sosnowski) (#35210) - **worker**: make MessageEvent class more Web-compatible (Anna Henningsen) (#35496) - **worker**: set trackUnmanagedFds to true by default (Anna Henningsen) (#34394) - **worker**: rename error code to be more accurate (Anna Henningsen) (#33872) PR-URL: #35014

benjamingr · 2020-10-28T14:09:40Z

I totally missed this - I didn't know we expose them as globals - this is cool.

`EventTarget` is exposed on the global scope, there is no need to use `--expose-internals` flag in the tests. Refs: nodejs#35496 PR-URL: nodejs#36002 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

`EventTarget` is exposed on the global scope, there is no need to use `--expose-internals` flag in the tests. Refs: #35496 PR-URL: #36002 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

PR-URL: nodejs#35496 Fixes: nodejs#35495 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Khaidi Chu <i@2333.moe>

Add - Event - EventTarget - MessagePort - MessageChannel - MessageEvent to the set of global objects, since they are available now and behave like they do in the browser. Fixes: nodejs#35495 PR-URL: nodejs#35496 Reviewed-By: Rich Trott <rtrott@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com> Reviewed-By: Myles Borins <myles.borins@gmail.com> Reviewed-By: Shelley Vohr <codebytere@gmail.com> Reviewed-By: Michael Dawson <midawson@redhat.com> Reviewed-By: Khaidi Chu <i@2333.moe>

ExE-Boss · 2021-01-25T08:01:12Z

doc/api/events.md

@@ -1080,7 +1086,7 @@ Neither the `EventTarget` nor `Event` classes are available for end
 user code to create.


This sentence is no longer true.

Suggested change

user code to create.

I’m fixing that in #37059.

addaleax added 2 commits October 4, 2020 14:14

worker: make MessageEvent class more Web-compatible

f07229f

lib: add EventTarget-related browser globals

3ea5dc1

Add - Event - EventTarget - MessagePort - MessageChannel - MessageEvent to the set of global objects, since they are available now and behave like they do in the browser. Fixes: nodejs#35495

addaleax added semver-major PRs that contain breaking changes and should be released in the next major version. tsc-agenda Issues and PRs to discuss during the meetings of the TSC. eventtarget Issues and PRs related to the EventTarget implementation. labels Oct 4, 2020

nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. lib / src Issues and PRs related to general changes in the lib or src directory. labels Oct 4, 2020

Trott approved these changes Oct 4, 2020

View reviewed changes

jasnell approved these changes Oct 4, 2020

View reviewed changes

addaleax added the notable-change PRs with changes that should be highlighted in changelogs. label Oct 4, 2020

fixup! lib: add EventTarget-related browser globals

1e27ac9

joyeecheung approved these changes Oct 4, 2020

View reviewed changes

MylesBorins approved these changes Oct 5, 2020

View reviewed changes

codebytere approved these changes Oct 5, 2020

View reviewed changes

mhdawson mentioned this pull request Oct 5, 2020

Node.js Technical Steering Committee (TSC) Meeting 2020-10-08 nodejs/TSC#935

Closed

mhdawson approved these changes Oct 5, 2020

View reviewed changes

addaleax added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. request-ci Add this label to start a Jenkins CI on a PR. labels Oct 8, 2020

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 8, 2020

XadillaX approved these changes Oct 9, 2020

View reviewed changes

aduh95 added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 11, 2020

github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 11, 2020

github-actions bot closed this Oct 11, 2020

BethGriggs mentioned this pull request Oct 14, 2020

2020-10-20, Version 15.0.0 (Current) #35014

Merged

addaleax deleted the eventtarget-globals branch October 18, 2020 12:48

ExE-Boss mentioned this pull request Oct 26, 2020

events: make abort_controller event trusted #35811

Closed

3 tasks

aduh95 mentioned this pull request Nov 6, 2020

test: use global.EventTarget instead of internals #36002

Merged

3 tasks

ExE-Boss mentioned this pull request Jan 25, 2021

doc: EventTarget and Event are available to user code since v15.0.0 #37059

Closed

ExE-Boss suggested changes Jan 25, 2021

View reviewed changes

DefinitelyMaybe mentioned this pull request Feb 21, 2021

EventDispatcher converted to es6 mrdoob/three.js#20943

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lib: add EventTarget-related browser globals #35496

lib: add EventTarget-related browser globals #35496

addaleax commented Oct 4, 2020

nodejs-github-bot commented Oct 4, 2020

addaleax commented Oct 4, 2020

nodejs-github-bot commented Oct 4, 2020 •

edited by addaleax

Loading

MylesBorins left a comment

mhdawson left a comment

BridgeAR commented Oct 8, 2020

BridgeAR commented Oct 8, 2020

addaleax commented Oct 8, 2020

nodejs-github-bot commented Oct 8, 2020

BridgeAR commented Oct 9, 2020

nodejs-github-bot commented Oct 9, 2020

XadillaX left a comment

github-actions bot commented Oct 11, 2020

benjamingr commented Oct 28, 2020

ExE-Boss Jan 25, 2021

		@@ -1080,7 +1086,7 @@ Neither the `EventTarget` nor `Event` classes are available for end
		user code to create.

lib: add EventTarget-related browser globals #35496

lib: add EventTarget-related browser globals #35496

Conversation

addaleax commented Oct 4, 2020

worker: make MessageEvent class more Web-compatible

lib: add EventTarget-related browser globals

Checklist

nodejs-github-bot commented Oct 4, 2020

addaleax commented Oct 4, 2020

nodejs-github-bot commented Oct 4, 2020 • edited by addaleax Loading

MylesBorins left a comment

Choose a reason for hiding this comment

mhdawson left a comment

Choose a reason for hiding this comment

BridgeAR commented Oct 8, 2020

BridgeAR commented Oct 8, 2020

addaleax commented Oct 8, 2020

nodejs-github-bot commented Oct 8, 2020

BridgeAR commented Oct 9, 2020

nodejs-github-bot commented Oct 9, 2020

XadillaX left a comment

Choose a reason for hiding this comment

github-actions bot commented Oct 11, 2020

benjamingr commented Oct 28, 2020

ExE-Boss Jan 25, 2021

Choose a reason for hiding this comment

nodejs-github-bot commented Oct 4, 2020 •

edited by addaleax

Loading