Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: mark test-webcrypto-encrypt-decrypt-aes flaky #35587

Closed
wants to merge 1 commit into from
Closed

test: mark test-webcrypto-encrypt-decrypt-aes flaky #35587

wants to merge 1 commit into from

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Oct 10, 2020

Appears to be flaky only on rhe17-390x. Will be investigating

refs: #35586

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • commit message follows commit guidelines

@jasnell
test: mark test-webcrypto-encrypt-decrypt-aes flaky
94fcd54 
Appears to be flaky only on rhe17-390x. Will be investigating

refs: nodejs#35586
@nodejs-github-bot nodejs-github-bot added the test Issues and PRs related to the tests. label Oct 10, 2020
@jasnell jasnell added flaky-test Issues and PRs related to the tests with unstable failures on the CI. crypto Issues and PRs related to the crypto subsystem. labels Oct 10, 2020
@richardlau
Copy link
Member

cc @nodejs/platform-s390

@jasnell jasnell added the fast-track PRs that do not need to wait for 48 hours to land. label Oct 11, 2020
@jasnell
Copy link
Member Author

jasnell commented Oct 11, 2020

Please 👍🏻 to fast-track

@jasnell jasnell added the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2020
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Oct 11, 2020
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Oct 12, 2020 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/33546/ 💚

@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Oct 13, 2020
mcollina
mcollina approved these changes Oct 13, 2020
View reviewed changes
Copy link
Member

@mcollina mcollina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm + fast track

@jasnell jasnell added the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 13, 2020
@github-actions github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Oct 13, 2020
@github-actions
Copy link
Contributor

Landed in f7ed5f4...efe60a5

@github-actions github-actions bot closed this Oct 13, 2020
nodejs-github-bot pushed a commit that referenced this pull request Oct 13, 2020
@jasnell @nodejs-github-bot
test: mark test-webcrypto-encrypt-decrypt-aes flaky
efe60a5 
Appears to be flaky only on rhe17-390x. Will be investigating

refs: #35586

PR-URL: #35587
Refs: #35586
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
MylesBorins pushed a commit that referenced this pull request Oct 14, 2020
@jasnell @MylesBorins
test: mark test-webcrypto-encrypt-decrypt-aes flaky
3d21792 
Appears to be flaky only on rhe17-390x. Will be investigating

refs: #35586

PR-URL: #35587
Refs: #35586
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Oct 14, 2020
Merged
joesepi pushed a commit to joesepi/node that referenced this pull request Jan 8, 2021
@jasnell @joesepi
test: mark test-webcrypto-encrypt-decrypt-aes flaky
b630e69 
Appears to be flaky only on rhe17-390x. Will be investigating

refs: nodejs#35586

PR-URL: nodejs#35587
Refs: nodejs#35586
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Matteo Collina <matteo.collina@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@mcollina mcollina mcollina approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. crypto Issues and PRs related to the crypto subsystem. fast-track PRs that do not need to wait for 48 hours to land. flaky-test Issues and PRs related to the tests with unstable failures on the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@jasnell @richardlau @nodejs-github-bot @mcollina @Trott