Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: fix REPLACEME typo #35617

Closed
wants to merge 1 commit into from
Closed

doc: fix REPLACEME typo #35617

wants to merge 1 commit into from

Conversation

cjihrig
Copy link
Contributor

@cjihrig cjihrig commented Oct 12, 2020

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations. labels Oct 12, 2020
aduh95
aduh95 approved these changes Oct 12, 2020
View reviewed changes
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI I've also included this change on #35575 (which just needs an approval to land).

@bcoe
Copy link
Contributor

bcoe commented Oct 12, 2020

@cjihrig @aduh95 should we just go ahead and land #35575, looks quite safe to fast track IMO.

@aduh95
Copy link
Contributor

aduh95 commented Oct 12, 2020

@cjihrig @aduh95 should we just go ahead and land #35575, looks quite safe to fast track IMO.

Fine with me! That would unblock nodejs/remark-preset-lint-node#139 which can unsure this doesn't happen again in the future ;)

@cjihrig
Copy link
Contributor Author

cjihrig commented Oct 12, 2020

Closing in favor of #35575

@cjihrig cjihrig closed this Oct 12, 2020
@cjihrig cjihrig deleted the typo branch October 12, 2020 18:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Flarna Flarna Flarna approved these changes

@aduh95 aduh95 aduh95 approved these changes

@gireeshpunathil gireeshpunathil gireeshpunathil approved these changes

@richardlau richardlau richardlau approved these changes

@lpinca lpinca lpinca approved these changes

@bcoe bcoe bcoe approved these changes

Assignees
No one assigned
Labels
deprecations Issues and PRs related to deprecations. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@cjihrig @bcoe @aduh95 @lpinca @richardlau @gireeshpunathil @Flarna @nodejs-github-bot