doc: made code spans more visible #3573
Conversation
|
LGTM |
| @@ -339,6 +339,8 @@ p code, | |||
| li code { | |||
| font-size: 0.9em; | |||
| color: #040404; | |||
| background-color: #f2f5f0; | |||
| padding: 0.2em; | |||
There was a problem hiding this comment.
I think a padding of 0.2em 0.4em would look better visually, it's what GitHub does too (They do it through a unicode space in :before and :after) to make the left and right padding slightly larger.
|
LGTM |
phillipj
force-pushed
the
doc-code-visibility
branch
from
cca141e
to
ef2e668
Compare
@silverwind agreed, just updated with a little extra horizontal padding.
|
|
LGTM One thing that bugs me a bit is that |
This makes the code spans in the API docs more visible and therefore readable by adding some background color. PR-URL: #3573 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
|
Thanks. Landed in d995b72. |
|
Any chance this could be backported to |
|
There shouldn't be any problem getting this in to v4 :-) |
This makes the code spans in the API docs more visible and therefore readable by adding some background color. PR-URL: #3573 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
This makes the code spans in the API docs more visible and therefore readable by adding some background color. PR-URL: #3573 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
|
landed in lts-v4.x-staging as 08ab9f3 |
|
@silverwind does this need a land-on-v5.x tag if it is on master? |
|
@thealphanerd No, that tag was unnecessary ;) |
|
|
|
Thanks @thealphanerd! |
This makes the code spans in the API docs more visible and therefore readable by adding some background color. PR-URL: #3573 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
This makes the code spans in the API docs more visible and therefore readable by adding some background color. PR-URL: #3573 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
This makes the code spans in the API docs more visible and therefore readable by adding some background color. PR-URL: #3573 Reviewed-By: Evan Lucas <evanlucas@me.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Roman Reiss <me@silverwind.io>
This makes the code spans in the API docs alot more visible and therefore readable by adding some background color. Its more or less what github.com does, and what we decided to do on nodejs.org with nodejs/nodejs.org#146.
Closes an issue raised about API docs readability in nodejs/nodejs.org#121.