-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
child_process: don't fork bomb ourselves from -e #3575
Conversation
LGTM |
LGTM |
Remove the `-e` argument from process.execArgv in child_process.fork() to keep `node -e 'require("child_process").fork("empty.js")'` from spawning itself recursively. Fixes: nodejs#3574 PR-URL: nodejs#3575 Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>
suggesting this goes into |
Agreed but likely better to land it post v4.2.2 |
It's not a regression in any way (it's a buglet that apparently goes all the way back to v0.6) so it would IMO be perfectly acceptable to leave it out of LTS. |
@bnoordhuis .. noted! 👍 On Fri, Oct 30, 2015 at 9:55 AM, Ben Noordhuis notifications@github.com
|
@jasnell @bnoordhuis @rvagg has this spent enough time in 5.1.0? |
@thealphanerd ... I'd say yes. |
Yes, I think so. EDIT: I see you landed it a few minutes ago. :-) |
Remove the
-e
argument from process.execArgv in child_process.fork()to keep
node -e 'require("child_process").fork("empty.js")'
fromspawning itself recursively.
Fixes: #3574
R=@Trott
CI: https://ci.nodejs.org/job/node-test-pull-request/643/