[12.x] doc: update fs promise-based examples #35760
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
doc
aduh95
reviewed
Oct 22, 2020
nodejs#34843 was cherry-picked onto `v12.x-staging` in 961844d but the `fs/promises` API, as used in the examples, is only available from Node.js 14. Change the added examples to use `require(fs).promises` instead.
richardlau
changed the title
aduh95
approved these changes
Oct 22, 2020
lpinca
approved these changes
Oct 23, 2020
fhinkel
approved these changes
Oct 26, 2020
rickyes
approved these changes
Oct 27, 2020
targos
approved these changes
Oct 27, 2020
rickyes
added
the
author ready
antsmartian
approved these changes
Oct 27, 2020
MylesBorins
pushed a commit
that referenced
this pull request
Nov 3, 2020
#34843 was cherry-picked onto `v12.x-staging` in 961844d but the `fs/promises` API, as used in the examples, is only available from Node.js 14. Change the added examples to use `require(fs).promises` instead. PR-URL: #35760 Fixes: #35740 Refs: #34843 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
|
landed in 32d45a3 |
Merged
MylesBorins
pushed a commit
that referenced
this pull request
Nov 16, 2020
#34843 was cherry-picked onto `v12.x-staging` in 961844d but the `fs/promises` API, as used in the examples, is only available from Node.js 14. Change the added examples to use `require(fs).promises` instead. PR-URL: #35760 Fixes: #35740 Refs: #34843 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Franziska Hinkelmann <franziska.hinkelmann@gmail.com> Reviewed-By: Ricky Zhou <0x19951125@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Anto Aravinth <anto.aravinth.cse@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#34843 was cherry-picked onto
v12.x-stagingin 961844d but thefs/promisesAPI, as usedin the examples, is only available from Node.js 14. Change the
added examples to use
require(fs).promisesinstead.Fixes: #35740
Refs: #34843
Checklist
make -j4 test(UNIX), orvcbuild test(Windows) passes