Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix comment #35913

Closed
wants to merge 1 commit into from
Closed

fix comment #35913

wants to merge 1 commit into from

Conversation

angrymouse
Copy link
Contributor

@angrymouse angrymouse commented Nov 1, 2020

Fixed incorrect path in comment for posix.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added doc Issues and PRs related to the documentations. path Issues and PRs related to the path subsystem. labels Nov 1, 2020
Copy link
Contributor

@aduh95 aduh95 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here's the result on my machine:

$ node -p "path.posix.basename('/tmp/myfile.html')"
myfile.html

@aduh95
Copy link
Contributor

aduh95 commented Nov 1, 2020

@angrymouse Maybe there is a bug on the Node.js version you are using, but the path.posix methods should definitely not return a Windows-like path. If that's what you are seeing on you're machine, you should check to see if you are using an up-to-date version of Node.js, and if you are, fill an issue on this repo so it can be fixed.

@Trott Trott closed this Nov 2, 2020
@Trott Trott added the invalid Issues and PRs that are invalid. label Nov 2, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. invalid Issues and PRs that are invalid. path Issues and PRs related to the path subsystem.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants