fs: support abortsignal in writeFile #35993

benjamingr · 2020-11-06T11:48:51Z

Now that #35911 is landed the next suggestion in #35877 by @mcollina was fs.writeFile (here #35877 (comment) ) - so I am going over the suggestions one by one and adding AbortSignal support.

This PR lets you abort an ongoing writeFile request.

const controller = new AbortController();
const { signal } = controller;
const data = new Uint8Array(Buffer.from('Hello Node.js'));
(async () => {
  try {
    await fs.writeFile('message.txt', data, { signal });
  } catch (err) {
  // When a request is aborted - err is an AbortError
  }
})();
// When the request should be aborted
controller.abort();

Note that unlike readFile this is very stateful - so some of the data will be written to the file (this is expected IMO). I vaguely recall in the summit @addaleax has something smart to say regarding the error but I don't remember the conclusion. I am happy to tack the offset (how many bytes were written) on the AbortError if that would help.

aduh95 · 2020-11-06T11:52:20Z

lib/internal/fs/promises.js


  const fd = await open(path, flag, options.mode);
-  return writeFileHandle(fd, data).finally(fd.close);
+  if (options.signal && options.signal.aborted) {


Suggested change

if (options.signal && options.signal.aborted) {

if (options.signal?.aborted) {

Bacause no backporting and 12.x?

AbortController is not available on v12, is it?

lib/internal/fs/promises.js

benjamingr · 2020-11-06T11:54:47Z

@nodejs/documentation anyone can help me with the "SyntaxError: Unexpected token (1421:13)" acorn error I'm seeing?

aduh95 · 2020-11-06T12:10:23Z

@nodejs/documentation anyone can help me with the "SyntaxError: Unexpected token (1421:13)" acorn error I'm seeing?

It's related to optional chaining. Fixed by #35994.

benjamingr · 2020-11-06T12:20:51Z

@aduh95

It's related to optional chaining. Fixed by #35994.

That makes sense sort of but... I did not use optional chaining in the docs so why is that failing?

aduh95 · 2020-11-06T13:18:23Z

That makes sense sort of but... I did not use optional chaining in the docs so why is that failing?

Not sure either, acorn parsing was added back in #22405.

richardlau · 2020-11-06T20:09:52Z

The docs build parses the JavaScript source to generate apilinks.json, e.g. https://nodejs.org/docs/v15.1.0/apilinks.json. This file maps methods to the line numbers in the source file and I believe it's used by some IDEs.

doc/api/fs.md

jasnell · 2020-11-06T20:28:03Z

doc/api/fs.md

+const { signal } = controller;
+const data = new Uint8Array(Buffer.from('Hello Node.js'));
+fs.writeFile('message.txt', data, { signal }, (err) => {
+  // When a request is aborted - the callback is called with an AbortError


This may be a bit difficult, and is likely something that we should tackle later in a separate PR, but it would be helpful if this reported the number of bytes known to have been written at the point of failure/cancelation.

Yeah, I asked in the description it's actually pretty easy to do - but I remember there were really good arguments regarding whether or not we should do this (in the summit, by @addaleax IIRC) and I don't remember what the conclusion was.

Adding the number of bytes written is actually technically pretty easy here if we just want to approximate how much was written since the last write since we don't actually abort writes in progress only writeAll

Right – I think we basically agreed to see cancellation is a way of expressing disinterest in the result of an operation. Not reporting the number of written bytes goes in line with that. More importantly, if we add cancellation support to the actual fs operations underneath – as we should – then these numbers become inherently unreliable. I would not be in favour of adding this, if somebody wants it, then they should use fs.write() directly without cancelling.

jasnell · 2020-11-06T20:28:41Z

doc/api/fs.md

+```
+
+Aborting an ongoing request does not abort individual operating
+system requests but rather the internal buffering `fs.writeFile` performs.


Users who are unfamiliar with how writeFile works under the covers may find this sentence confusing.

How do you propose we deal with this? Add an extra note to writeFile explaining how it works and suggesting a createWriteStream for performacne sensitive stuff like we do with readFile?

I think it's better to explain how this works underneath instead, and then include the above sentence.

@mcollina @jasnell done PTAL

nodejs-github-bot · 2020-11-07T16:35:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/34175/

nodejs#35993 (comment)

#35993 (comment) PR-URL: #35995 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

benjamingr · 2020-11-10T07:43:43Z

This needs a rebase and some reviews ^^

@jasnell @mcollina any chance this could get a look? It's weird we support it in readFile but not writeFile

aduh95 · 2020-11-10T08:47:34Z

lib/fs.js

    return;
  }

+  if (options.signal && options.signal.aborted) {


Suggested change

if (options.signal && options.signal.aborted) {

if (options.signal?.aborted) {

nodejs-github-bot · 2020-11-10T09:12:03Z

CI: https://ci.nodejs.org/job/node-test-pull-request/34271/

github-actions · 2020-11-10T14:30:22Z

Landed in 9afe2b6...d9dadac

PR-URL: #35993 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

#35993 (comment) PR-URL: #35995 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

PR-URL: #35993 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Notable changes: * events: * getEventListeners static (Benjamin Gruenbaum) (#35991) * fs: * support abortsignal in writeFile (Benjamin Gruenbaum) (#35993) * add support for AbortSignal in readFile (Benjamin Gruenbaum) (#35911) * stream: * fix thrown object reference (Gil Pedersen) (#36065) PR URL: #36055

#35993 (comment) PR-URL: #35995 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

PR-URL: nodejs#35993 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

PR-URL: #35993 Backport-PR-URL: #38386 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

Refs: nodejs#33716 Refs: nodejs#35993 Refs: nodejs#35911

Refs: #33716 Refs: #35993 Refs: #35911 PR-URL: #39972 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

PR-URL: #39972 Refs: #33716 Refs: #35993 Refs: #35911 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

Refs: #33716 Refs: #35993 Refs: #35911 PR-URL: #39972 Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Juan José Arboleda <soyjuanarbol@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Tobias Nießen <tniessen@tnie.de>

nodejs-github-bot added the fs Issues and PRs related to the fs subsystem / file system. label Nov 6, 2020

benjamingr force-pushed the abort-signal-write-file branch from 01d0a51 to cd7b999 Compare November 6, 2020 11:49

aduh95 reviewed Nov 6, 2020

View reviewed changes

baruchiro mentioned this pull request Nov 6, 2020

fs: replace finally with PromisePrototypeFinally #35995

Closed

2 tasks

jasnell reviewed Nov 6, 2020

View reviewed changes

doc/api/fs.md Outdated Show resolved Hide resolved

jasnell reviewed Nov 6, 2020

View reviewed changes

benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2020

benjamingr requested a review from mcollina November 7, 2020 16:28

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 7, 2020

baruchiro added a commit to baruchiro/node that referenced this pull request Nov 8, 2020

fs: replace finally with PromisePrototypeFinally

b3d82e0

nodejs#35993 (comment)

benjamingr force-pushed the abort-signal-write-file branch from ed7d240 to 1072fc9 Compare November 9, 2020 10:34

benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 9, 2020

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 9, 2020

nodejs-github-bot pushed a commit that referenced this pull request Nov 9, 2020

fs: replace finally with PromisePrototypeFinally

a8b9ede

#35993 (comment) PR-URL: #35995 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

aduh95 reviewed Nov 10, 2020

View reviewed changes

fs: support abortsignal in writeFile

017246b

benjamingr force-pushed the abort-signal-write-file branch from 1072fc9 to 017246b Compare November 10, 2020 08:56

benjamingr added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2020

github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 10, 2020

github-actions bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Nov 10, 2020

github-actions bot closed this Nov 10, 2020

nodejs-github-bot pushed a commit that referenced this pull request Nov 10, 2020

fs: support abortsignal in writeFile

d9dadac

PR-URL: #35993 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

benjamingr deleted the abort-signal-write-file branch November 10, 2020 14:31

benjamingr added the semver-minor PRs that contain new features and should be released in the next minor version. label Nov 10, 2020

danielleadams pushed a commit that referenced this pull request Nov 10, 2020

fs: replace finally with PromisePrototypeFinally

7ef9c70

#35993 (comment) PR-URL: #35995 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

danielleadams pushed a commit that referenced this pull request Nov 10, 2020

fs: support abortsignal in writeFile

ccf9f0e

PR-URL: #35993 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

danielleadams mentioned this pull request Nov 10, 2020

v15.2.0 proposal #36055

Merged

BethGriggs pushed a commit that referenced this pull request Dec 9, 2020

fs: replace finally with PromisePrototypeFinally

1ed0a03

#35993 (comment) PR-URL: #35995 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

BethGriggs pushed a commit that referenced this pull request Dec 10, 2020

fs: replace finally with PromisePrototypeFinally

affa710

#35993 (comment) PR-URL: #35995 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

BethGriggs pushed a commit that referenced this pull request Dec 15, 2020

fs: replace finally with PromisePrototypeFinally

7c3b6f1

#35993 (comment) PR-URL: #35995 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Rich Trott <rtrott@gmail.com>

targos added the backport-open-v14.x label Apr 24, 2021

targos pushed a commit to targos/node that referenced this pull request Apr 24, 2021

fs: support abortsignal in writeFile

39b8c28

PR-URL: nodejs#35993 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

targos mentioned this pull request Apr 24, 2021

[v14.x] Backport AbortController and friends #38386

Closed

targos pushed a commit to targos/node that referenced this pull request Apr 26, 2021

fs: support abortsignal in writeFile

55b6b3a

PR-URL: nodejs#35993 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

targos pushed a commit to targos/node that referenced this pull request Apr 30, 2021

fs: support abortsignal in writeFile

ceef7e3

PR-URL: nodejs#35993 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

targos pushed a commit that referenced this pull request Apr 30, 2021

fs: support abortsignal in writeFile

219cd00

PR-URL: #35993 Backport-PR-URL: #38386 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Matteo Collina <matteo.collina@gmail.com>

targos added backported-to-v14.x and removed backport-open-v14.x labels Apr 30, 2021

danielleadams mentioned this pull request May 3, 2021

v14.17.0 proposal #38507

Merged

aduh95 added a commit to aduh95/node that referenced this pull request Sep 1, 2021

doc: fix missing history version in fs.md

9db9ae6

Refs: nodejs#33716 Refs: nodejs#35993 Refs: nodejs#35911

aduh95 mentioned this pull request Sep 1, 2021

doc: fix missing history version in fs.md #39972

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

fs: support abortsignal in writeFile #35993

fs: support abortsignal in writeFile #35993

benjamingr commented Nov 6, 2020

aduh95 Nov 6, 2020

benjamingr Nov 6, 2020

aduh95 Nov 10, 2020

benjamingr commented Nov 6, 2020

aduh95 commented Nov 6, 2020

benjamingr commented Nov 6, 2020

aduh95 commented Nov 6, 2020

richardlau commented Nov 6, 2020

jasnell Nov 6, 2020

benjamingr Nov 7, 2020

addaleax Nov 7, 2020

jasnell Nov 6, 2020

benjamingr Nov 7, 2020

mcollina Nov 7, 2020

benjamingr Nov 9, 2020 •

edited

Loading

nodejs-github-bot commented Nov 7, 2020

benjamingr commented Nov 10, 2020

aduh95 Nov 10, 2020

nodejs-github-bot commented Nov 10, 2020

github-actions bot commented Nov 10, 2020

	if (options.signal && options.signal.aborted) {
	if (options.signal?.aborted) {

fs: support abortsignal in writeFile #35993

fs: support abortsignal in writeFile #35993

Conversation

benjamingr commented Nov 6, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benjamingr commented Nov 6, 2020

aduh95 commented Nov 6, 2020

benjamingr commented Nov 6, 2020

aduh95 commented Nov 6, 2020

richardlau commented Nov 6, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

benjamingr Nov 9, 2020 • edited Loading

Choose a reason for hiding this comment

nodejs-github-bot commented Nov 7, 2020

benjamingr commented Nov 10, 2020

Choose a reason for hiding this comment

nodejs-github-bot commented Nov 10, 2020

github-actions bot commented Nov 10, 2020

benjamingr Nov 9, 2020 •

edited

Loading