Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: cleanup events docs #36100

Closed
wants to merge 1 commit into from
Closed

Conversation

jasnell
Copy link
Member

@jasnell jasnell commented Nov 12, 2020

This PR depends on #36001 which must land first, and addresses a concern
over the documentation structure raised in the review of #36001.

The first commit is from #36001

/cc @Trott

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • documentation is changed or added
  • commit message follows commit guidelines

@nodejs-github-bot nodejs-github-bot added the events Issues and PRs related to the events subsystem / EventEmitter. label Nov 12, 2020
@Trott
Copy link
Member

Trott commented Nov 13, 2020

@nodejs/events @nodejs/documentation

@aymen94
Copy link
Member

aymen94 commented Nov 15, 2020

LGTM

lib/events.js Outdated Show resolved Hide resolved
Signed-off-by: James M Snell <jasnell@gmail.com>
@jasnell jasnell force-pushed the cleanup-events-docs branch from 26abaa7 to 3b6f6e1 Compare November 23, 2020 16:01
@jasnell jasnell added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Nov 23, 2020
jasnell added a commit that referenced this pull request Nov 23, 2020
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36100
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@jasnell
Copy link
Member Author

jasnell commented Nov 23, 2020

Landed in abe3456

@jasnell jasnell closed this Nov 23, 2020
@benjamingr
Copy link
Member

@jasnell any chance you can land the graduate EventTarget/AbortController PR next?

@jasnell
Copy link
Member Author

jasnell commented Nov 23, 2020

In the process of doing so. Running one final ci after rebasing

danielleadams pushed a commit that referenced this pull request Dec 7, 2020
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36100
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@danielleadams danielleadams mentioned this pull request Dec 7, 2020
targos pushed a commit that referenced this pull request May 30, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36100
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request May 31, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36100
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36100
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36100
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jun 11, 2021
Signed-off-by: James M Snell <jasnell@gmail.com>

PR-URL: #36100
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. events Issues and PRs related to the events subsystem / EventEmitter.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants