Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: check callback type of imcoming timeout #3618

Closed
wants to merge 1 commit into from
Closed

http: check callback type of imcoming timeout #3618

wants to merge 1 commit into from

Conversation

aks-
Copy link
Member

@aks- aks- commented Oct 31, 2015

No description provided.

@aks-
Copy link
Member Author

aks- commented Oct 31, 2015

cc @nodejs/http

@dougwilson
Copy link
Member

👎 , protection already exists in EventEmitter.prototype.addListener.

@aks-
Copy link
Member Author

aks- commented Oct 31, 2015

@dougwilson Oho I see. Well then should we have this check here https://github.com/nodejs/node/blob/master/lib/_http_outgoing.js#L93-L97

@dougwilson
Copy link
Member

Unsure. Was added in PR #3090 , which can help us decide.

@mscdex mscdex added the http Issues or PRs related to the http subsystem. label Nov 1, 2015
@MylesBorins
Copy link
Contributor

Dupe of #3539

@aredridel
Copy link
Contributor

Kind of a dupe, anyway. That other PR covers other cases.

YurySolovyov
YurySolovyov reviewed Nov 1, 2015
View reviewed changes
lib/_http_incoming.js
@@ -63,8 +63,11 @@ exports.IncomingMessage = IncomingMessage;


IncomingMessage.prototype.setTimeout = function(msecs, callback) {
if (callback)
if (callback) {
if (typeof callback != 'function')
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

should be strict check IMO

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Preferred, yes. Although, typeof only ever returns strings.

@aks- aks- mentioned this pull request Nov 2, 2015
Closed
Fishrock123 pushed a commit that referenced this pull request Nov 5, 2015
@aks- @Fishrock123
http: remove unneeded cb check from setTimeout()
8625a38 
- This check is already covered in EventEmitter#addListener()

Refs: #3618
PR-URL: #3631
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
@Fishrock123
Copy link
Contributor

Replacement landed in 8625a38

@Fishrock123 Fishrock123 closed this Nov 5, 2015
rvagg pushed a commit that referenced this pull request Nov 7, 2015
@aks- @rvagg
http: remove unneeded cb check from setTimeout()
a7f28a0 
- This check is already covered in EventEmitter#addListener()

Refs: #3618
PR-URL: #3631
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Sakthipriyan Vairamani <thechargingvolcano@gmail.com>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@aks- @dougwilson @MylesBorins @aredridel @Fishrock123 @YurySolovyov @mscdex