Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: note v15.0.0 changed default --unhandled-rejections=throw #36361

Merged
merged 1 commit into from
Dec 12, 2020
Merged

docs: note v15.0.0 changed default --unhandled-rejections=throw #36361

merged 1 commit into from
Dec 12, 2020

Conversation

kaizhu256
Copy link
Contributor

Checklist

@nodejs-github-bot nodejs-github-bot added cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations. labels Dec 3, 2020
Trott
Trott reviewed Dec 7, 2020
View reviewed changes
doc/api/cli.md Outdated Show resolved Hide resolved
@Trott
Copy link
Member

Trott commented Dec 7, 2020

Left a suggestion but looks good to me either way.

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Dec 7, 2020
@kaizhu256 @Trott
doc: note v15.0.0 changed default --unhandled-rejections=throw
d50b2ff 
PR-URL: nodejs#36361
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented Dec 12, 2020

Landed in d50b2ff

@Trott Trott merged commit d50b2ff into nodejs:master Dec 12, 2020
@Trott
Copy link
Member

Trott commented Dec 12, 2020

Thanks for the contribution! 🎉

@kaizhu256
Copy link
Contributor Author

Woot

targos pushed a commit that referenced this pull request Dec 21, 2020
@kaizhu256 @targos
doc: note v15.0.0 changed default --unhandled-rejections=throw
62bfe3d 
PR-URL: #36361
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Mary Marchini <oss@mmarchini.me>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Dec 22, 2020
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aduh95 aduh95 aduh95 approved these changes

@mmarchini mmarchini mmarchini approved these changes

@lpinca lpinca lpinca approved these changes

@benjamingr benjamingr benjamingr approved these changes

@Trott Trott Trott approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. cli Issues and PRs related to the Node.js command line interface. doc Issues and PRs related to the documentations.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@kaizhu256 @Trott @benjamingr @lpinca @mmarchini @aduh95 @targos @nodejs-github-bot