Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

domains: emit uncaughtException when appropriate #3638

Closed
wants to merge 2 commits into from
Closed

domains: emit uncaughtException when appropriate #3638

wants to merge 2 commits into from

Commits on Nov 4, 2015

  1. domains: emit uncaughtException when appropriate 

    Fix node exiting due to an exception being thrown rather than emitting
an `'uncaughtException'` event on the process object when no error
handler is set on the domain within which an error is thrown and an
`'uncaughtException'` event listener is set on the process.

Fixes nodejs#3607.
    Julien Gilli committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    412dc11 View commit details
    Browse the repository at this point in the history

  2. domains: fix no error handler & abort-on-uncaught 

    Make the process abort if an error is thrown within a domain with no
error handler and `--abort-on-uncaught-exception` is used.

If the domain within which the error is thrown has no error handler,
but a domain further down the domains stack has one, the process will
not abort.

Fixes nodejs#3653
    Julien Gilli committed Nov 4, 2015
    Configuration menu
    Copy the full SHA
    68ca2b1 View commit details
    Browse the repository at this point in the history