Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

wip make policies not apply to the wrapper #36472

Closed
wants to merge 3 commits into from

Conversation

bmeck
Copy link
Member

@bmeck bmeck commented Dec 10, 2020

This PR makes it so policies don't have to apply to the wrapper for things like STDIN or --eval.

Currently this does keep the URL for the check at file:///...[eval] etc. Likely we should differentiate this on the policy rather than having it collide with a file on disk. I was thinking something like app:{[eval],[stdin]}. However, this does have a problem that the wrapper module path would differ from the policy. I'm open to any sort of disambiguation or punting that for now even.

Checklist
  • make -j4 test (UNIX), or vcbuild test (Windows) passes
  • tests and/or benchmarks are included
  • documentation is changed or added
  • commit message follows commit guidelines

@bmeck bmeck added the policy Issues and PRs related to the policy subsystem. label Dec 10, 2020
@nodejs-github-bot nodejs-github-bot added the process Issues and PRs related to the process subsystem. label Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
policy Issues and PRs related to the policy subsystem. process Issues and PRs related to the process subsystem. review wanted PRs that need reviews.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants