Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

domains: fix handling of uncaught exceptions #3654

Closed
wants to merge 1 commit into from
Closed

domains: fix handling of uncaught exceptions #3654

wants to merge 1 commit into from

Commits on Dec 11, 2015

  1. domains: fix handling of uncaught exceptions 

    Fix node exiting due to an exception being thrown rather than emitting
an `'uncaughtException'` event on the process object when:
1. no error handler is set on the domain within which an error is thrown
2. an `'uncaughtException'` event listener is set on the process

Also fix an issue where the process would not abort in the proper
function call if an error is thrown within a domain with no error
handler and `--abort-on-uncaught-exception` is used.

Finally, change the behavior of --abort-on-uncaught-exception so that,
if the domain within which the error is thrown has no error handler, but
a domain further up the domains stack has one, the process will not
abort.

Fixes nodejs#3607 and nodejs#3653.
    Julien Gilli committed Dec 11, 2015
    Configuration menu
    Copy the full SHA
    c76959a View commit details
    Browse the repository at this point in the history