Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

http: remove unused and undocumented httpAllowHalfOpen #36819

Closed
wants to merge 2 commits into from
Closed

http: remove unused and undocumented httpAllowHalfOpen #36819

wants to merge 2 commits into from

Conversation

ronag
Copy link
Member

@ronag ronag commented Jan 6, 2021

No description provided.

@ronag ronag requested a review from BridgeAR January 6, 2021 20:08
@nodejs-github-bot nodejs-github-bot added http Issues or PRs related to the http subsystem. https Issues or PRs related to the https subsystem. labels Jan 6, 2021
@ronag ronag removed the https Issues or PRs related to the https subsystem. label Jan 6, 2021
@ronag ronag requested a review from aduh95 January 6, 2021 20:08
@ronag
Copy link
Member Author

ronag commented Jan 6, 2021

@nodejs/http

@ronag ronag added the semver-major PRs that contain breaking changes and should be released in the next major version. label Jan 6, 2021
@ronag ronag changed the title http: remove unused and undocument httpAllowHalfOpen http: remove unused and undocumented httpAllowHalfOpen Jan 6, 2021
ronag
ronag commented Jan 6, 2021
View reviewed changes
lib/_http_server.js Outdated Show resolved Hide resolved
@lpinca
Copy link
Member

lpinca commented Jan 6, 2021

Are you sure it is unused? It's used in some tests and by userland modules like spdy.

@ronag
Copy link
Member Author

ronag commented Jan 6, 2021

Are you sure it is unused? It's used in some tests and by userland modules like spdy.

It seems I am wrong.

@ronag ronag closed this Jan 6, 2021
@wedataintelligence wedataintelligence mentioned this pull request Jan 12, 2023
Open
This was referenced Jan 12, 2023
Open
Open
@137717unity 137717unity mentioned this pull request Jan 13, 2023
Open
This was referenced Jan 13, 2023
Open
Open
Open
Open
Open
@snyk-bot snyk-bot mentioned this pull request Apr 25, 2023
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@BridgeAR BridgeAR Awaiting requested review from BridgeAR

@aduh95 aduh95 Awaiting requested review from aduh95

Assignees
No one assigned
Labels
http Issues or PRs related to the http subsystem. semver-major PRs that contain breaking changes and should be released in the next major version.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ronag @lpinca @nodejs-github-bot