deps: upgrade npm to 2.14.9 (for v4.x-staging) #3686
Conversation
othiym23
added
npm
|
I see the whitespace issues, and will rebase / apply the whitespace fix and push again. |
Dependency upgrades.
othiym23
force-pushed
the
npm-2.14.9-node-v4.x
branch
from
7d1c5bd to
43566db
Compare
|
Whitespace fix applied, and force-pushed. Also, reminded myself to read the release process docs more carefully in the future. ;) |
|
All tests passing on my local machine 10.10.5 (make && make test-npm) |
|
@thealphanerd That's not necessarily accurate. Pre npm 3 (i.e. pre-v5.x) you need to also do |
|
LGTM |
|
thanks for the heads up @Fishrock123 |
|
LGTM |
|
Will get this landed in v4.x-staging a bit later this week. |
Dependency upgrades. PR-URL: #3686 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
Landed in |
Dependency upgrades. PR-URL: #3686 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Dependency upgrades. PR-URL: #3686 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
There was never a CI run for this, right? See #4336 (comment) |
|
Entirely possible.
|
|
@ChALkeR CI runs are mostly useless for these, except to see if it |
|
should we have an npm CI run that run I should be able to spin that up on jenkins pretty quickly |
Dependency upgrades. PR-URL: #3686 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
@thealphanerd For 2.x it needs to do |
(Second verse, same as the first.)
Mostly just dependency upgrades and some small typo fixes.
make test-npmpassed, but again I'd like independent confirmation before merging.r: @Fishrock123