Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Read exactly two tokens from Linux transparent huge pages sysfs config #37065

Closed
wants to merge 20 commits into from
Closed

Read exactly two tokens from Linux transparent huge pages sysfs config #37065

wants to merge 20 commits into from

Commits on Jan 25, 2021

  1. src: simplify kernel transparent_hugepage enabled flag check by remov…

    …ing while loop
    
    There was an unexpected and hard-to-spot issue here: the /sys/kernel/mm/transparent_hugepage/enabled file contains three entries, and the std::ifstream reader was reading two values on each loop iteration, resulting in incorrect behaviour.
    jayaddison committed Jan 25, 2021
    Configuration menu
    Copy the full SHA
    5a07333 View commit details
    Browse the repository at this point in the history

Commits on Jan 26, 2021

  1. src: inspect kernel transparent_hugepage flag values without assuming…

    … their length or ordering
    jayaddison committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    72082b9 View commit details
    Browse the repository at this point in the history
  2. src: add an explicit default value for the 'enabled' bool variable

    Co-authored-by: Darshan Sen <raisinten@gmail.com>
    jayaddison and RaisinTen committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    53648a0 View commit details
    Browse the repository at this point in the history
  3. src: extract GetTransparentHugePagesConfiguration function to read sy…

    …stem huge tables configuration on Linux-based systems
    jayaddison committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    a7fe193 View commit details
    Browse the repository at this point in the history
  4. src: extract IsTransparentHugePagesEnabledViaConfiguration function t…

    …o determine huge tables enabled state based on the contents of a configuration stream
    jayaddison committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    72dd2f3 View commit details
    Browse the repository at this point in the history
  5. src: refactor: return early when we discover that huge tables is enab…

    …led in the configuration stream
    jayaddison committed Jan 26, 2021
    Configuration menu
    Copy the full SHA
    519f212 View commit details
    Browse the repository at this point in the history
  6. Configuration menu
    Copy the full SHA
    21ed800 View commit details
    Browse the repository at this point in the history
  7. Configuration menu
    Copy the full SHA
    03922c0 View commit details
    Browse the repository at this point in the history
  8. Configuration menu
    Copy the full SHA
    434e8b8 View commit details
    Browse the repository at this point in the history

Commits on Jan 27, 2021

  1. Configuration menu
    Copy the full SHA
    49b35e9 View commit details
    Browse the repository at this point in the history
  2. Revert "src: lint fixup: rename function to fit within column width c…

    …onstraint"
    
    This reverts commit 03922c0.
    jayaddison committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    24d4943 View commit details
    Browse the repository at this point in the history
  3. Revert "src: apply lint fix: use left-leaning pointers"

    This reverts commit 21ed800.
    jayaddison committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    250e013 View commit details
    Browse the repository at this point in the history
  4. Revert "src: refactor: return early when we discover that huge tables…

    … is enabled in the configuration stream"
    
    This reverts commit 519f212.
    jayaddison committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    53d148d View commit details
    Browse the repository at this point in the history
  5. Revert "src: extract IsTransparentHugePagesEnabledViaConfiguration fu…

    …nction to determine huge tables enabled state based on the contents of a configuration stream"
    
    This reverts commit 72dd2f3.
    jayaddison committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    759b809 View commit details
    Browse the repository at this point in the history
  6. Revert "src: extract GetTransparentHugePagesConfiguration function to…

    … read system huge tables configuration on Linux-based systems"
    
    This reverts commit a7fe193.
    jayaddison committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    37bf5f9 View commit details
    Browse the repository at this point in the history
  7. Revert "src: add an explicit default value for the 'enabled' bool var…

    …iable"
    
    This reverts commit 53648a0.
    jayaddison committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    e299a65 View commit details
    Browse the repository at this point in the history
  8. Revert "src: inspect kernel transparent_hugepage flag values without …

    …assuming their length or ordering"
    
    This reverts commit 72082b9.
    jayaddison committed Jan 27, 2021
    Configuration menu
    Copy the full SHA
    d00fce6 View commit details
    Browse the repository at this point in the history
  9. Configuration menu
    Copy the full SHA
    e7f1cf0 View commit details
    Browse the repository at this point in the history

Commits on Jan 28, 2021

  1. Configuration menu
    Copy the full SHA
    572b34a View commit details
    Browse the repository at this point in the history
  2. src: nit: update documentation reference to link to the line that the…

    … relevant function is declared on
    jayaddison committed Jan 28, 2021
    Configuration menu
    Copy the full SHA
    239589b View commit details
    Browse the repository at this point in the history