Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: rename N-API to Node-API #37259

Closed

Conversation

gabrielschulhof
Copy link
Contributor

No description provided.

@nodejs-github-bot nodejs-github-bot added the tools Issues and PRs related to the tools directory. label Feb 7, 2021
@gabrielschulhof gabrielschulhof added doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. labels Feb 7, 2021
tools/lint-md.js Outdated Show resolved Hide resolved
Trott added a commit to Trott/io.js that referenced this pull request Feb 8, 2021
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM although it is blocked until #37270 lands. (Please consider approving fast-tracking that PR.)

Trott added a commit to Trott/io.js that referenced this pull request Feb 8, 2021
This is a prerequisite for nodejs#37259.

PR-URL: nodejs#37270
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
gabrielschulhof pushed a commit that referenced this pull request Feb 8, 2021
Refs: nodejs/abi-stable-node#420
PR-URL: #37259
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
@gabrielschulhof
Copy link
Contributor Author

Landed in 2084f31.

@gabrielschulhof gabrielschulhof deleted the rename-n-api-doc branch February 8, 2021 17:10
@@ -33,14 +32,14 @@ properties:
using `napi_get_last_error_info`. More information can be found in the error
handling section [Error handling][].

The N-API is a C API that ensures ABI stability across Node.js versions
Node-API-API is a C API that ensures ABI stability across Node.js versions
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
Node-API-API is a C API that ensures ABI stability across Node.js versions
Node-API is a C API that ensures ABI stability across Node.js versions

danielleadams pushed a commit that referenced this pull request Feb 16, 2021
This is a prerequisite for #37259.

PR-URL: #37270
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
Refs: nodejs/abi-stable-node#420
PR-URL: #37259
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
This was referenced Feb 16, 2021
targos pushed a commit that referenced this pull request May 1, 2021
Refs: nodejs/abi-stable-node#420
PR-URL: #37259
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Gireesh Punathil <gpunathi@in.ibm.com>
targos pushed a commit that referenced this pull request May 1, 2021
This is a prerequisite for #37259.

PR-URL: #37270
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
danielleadams pushed a commit that referenced this pull request May 8, 2021
This is a prerequisite for #37259.

PR-URL: #37270
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Beth Griggs <bgriggs@redhat.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations. node-api Issues and PRs related to the Node-API. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants