Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

doc: apply sentence case to release doc headers #37349

Merged
merged 0 commits into from
Feb 15, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Feb 13, 2021

Our style is to use sentence case for headers and documentation titles.
The documentation for releases uses both sentence case and title case.
This change applies sentence case consistently throughout.

@nodejs-github-bot nodejs-github-bot added the doc Issues and PRs related to the documentations. label Feb 13, 2021
@RaisinTen
Copy link
Contributor

In the commit message:

  • setnece -> sentence
  • sentence-case -> sentence case

I guess, this could also be addressed while landing this.

@Trott
Copy link
Member Author

Trott commented Feb 13, 2021

In the commit message:

  • setnece -> sentence
  • sentence-case -> sentence case

I guess, this could also be addressed while landing this.

Fixed those and also propagated the capitalization changes to the table of contents. Thanks!

@Trott Trott changed the title doc: apply sentence-case to release doc headers doc: apply sentence case to release doc headers Feb 13, 2021
@Trott
Copy link
Member Author

Trott commented Feb 15, 2021

Landed in dd731e2

@Trott Trott closed this Feb 15, 2021
@Trott Trott deleted the release-sentence branch February 15, 2021 13:13
@Trott Trott merged commit dd731e2 into nodejs:master Feb 15, 2021
danielleadams pushed a commit that referenced this pull request Feb 16, 2021
Our style is to use sentence case for headers and documentation titles.
The documentation for releases uses both sentence case and title case.
This change applies sentence case consistently throughout.

PR-URL: #37349
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
This was referenced Feb 16, 2021
targos pushed a commit that referenced this pull request May 1, 2021
Our style is to use sentence case for headers and documentation titles.
The documentation for releases uses both sentence case and title case.
This change applies sentence case consistently throughout.

PR-URL: #37349
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc Issues and PRs related to the documentations.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants