Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: remove FLAKY status for test-async-hooks-http-parser-destroy #37636

Merged
merged 1 commit into from
Mar 8, 2021
Merged

test: remove FLAKY status for test-async-hooks-http-parser-destroy #37636

merged 1 commit into from
Mar 8, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Mar 6, 2021

This CI test failure hasn't been reported for some time.

Closes: #26610

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Mar 6, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36516/

@PoojaDurgad PoojaDurgad added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Mar 8, 2021
@Trott
test: remove FLAKY status for test-async-hooks-http-parser-destroy
20009d7 
This CI test failure hasn't been reported for some time.

Closes: nodejs#26610

PR-URL: nodejs#37636
Fixes: nodejs#26610
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@Trott Trott merged commit 20009d7 into nodejs:master Mar 8, 2021
@Trott
Copy link
Member Author

Trott commented Mar 8, 2021

Landed in 20009d7

@Trott Trott deleted the async-status branch March 8, 2021 17:39
danielleadams pushed a commit that referenced this pull request Mar 16, 2021
@Trott @danielleadams
test: remove FLAKY status for test-async-hooks-http-parser-destroy
1f63418 
This CI test failure hasn't been reported for some time.

Closes: #26610

PR-URL: #37636
Fixes: #26610
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@danielleadams danielleadams mentioned this pull request Mar 16, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@Trott @targos
test: remove FLAKY status for test-async-hooks-http-parser-destroy
376fcc7 
This CI test failure hasn't been reported for some time.

Closes: #26610

PR-URL: #37636
Fixes: #26610
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@marsonya marsonya marsonya approved these changes

@cjihrig cjihrig cjihrig approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

flaky: parallel/test-async-hooks-http-parser-destroy.js
6 participants
@Trott @nodejs-github-bot @targos @cjihrig @marsonya @PoojaDurgad