lib: implement AbortSignal.abort() #37693

jasnell · 2021-03-10T17:01:24Z

Implementation of AbortSignal.abort() to create an already aborted AbortSignal

Refs: whatwg/dom#960

nodejs-github-bot · 2021-03-11T16:01:58Z

CI: https://ci.nodejs.org/job/node-test-pull-request/36629/ 💚

benjamingr

LGTM, please pull in the WPTs you added :)

benjamingr · 2021-03-13T10:55:10Z

lib/internal/abort_controller.js

@@ -65,10 +69,10 @@ ObjectDefineProperty(AbortSignal.prototype, SymbolToStringTag, {

 defineEventHandler(AbortSignal.prototype, 'abort');

-function createAbortSignal() {
+function createAbortSignal(aborted = false) {


Why this approach rather than doing new AbortSignalesque?

new AbortSignal() is not permitted by the spec.

Oh, right, we ended up doing this and not the "fake parameter in constructor" approach.

jasnell · 2021-03-15T14:22:40Z

whatwg/dom#960 has landed. This can proceed

Signed-off-by: James M Snell <jasnell@gmail.com>

nodejs-github-bot · 2021-03-15T14:30:11Z

CI: https://ci.nodejs.org/job/node-test-pull-request/36717/

benjamingr

LGTM

Refs: whatwg/dom#960 PR-URL: #37693 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #37693 Refs: whatwg/dom#960 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

jasnell · 2021-03-15T15:25:44Z

Landed in 263bf4e and 1d740ec

benjamingr · 2021-03-15T17:27:43Z

Added "Notable Change" since I think it's justified - if you disagree feel free to remove @jasnell

Refs: whatwg/dom#960 PR-URL: #37693 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #37693 Refs: whatwg/dom#960 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

PR-URL: #37766 Notable changes: * crypto: * add optional callback to crypto.sign and crypto.verify (Filip Skokan) #37500 * support JWK objects in create\*Key (Filip Skokan) #37254 * deps: * update archs files for OpenSSL-1.1.1+quic (James M Snell) #37601 * switch openssl to quictls/openssl (James M Snell) #37601 * doc: * update maintaining-openssl guide (James M Snell) #37601 * fs: * improve fsPromises writeFile performance (Nitzan Uziely) #37610 * add promisified readFile benchmark (Nitzan Uziely) #37608 * improve fsPromises readFile performance (Nitzan Uziely) #37608 * lib: * implement AbortSignal.abort() (James M Snell) #37693 * node-api: * define version 8 (Gabriel Schulhof) #37652 * test: * update dom/abort tests (James M Snell) #37693 * fixup test to account for quic openssl version (James M Snell) #37601 * worker: * add setEnvironmentData/getEnvironmentData (James M Snell) #37486

Refs: whatwg/dom#960 PR-URL: #37693 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #37693 Refs: whatwg/dom#960 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

PR-URL: #37766 Notable changes: * crypto: * add optional callback to crypto.sign and crypto.verify (Filip Skokan) #37500 * support JWK objects in create\*Key (Filip Skokan) #37254 * deps: * update archs files for OpenSSL-1.1.1+quic (James M Snell) #37601 * switch openssl to quictls/openssl (James M Snell) #37601 * doc: * update maintaining-openssl guide (James M Snell) #37601 * fs: * improve fsPromises writeFile performance (Nitzan Uziely) #37610 * add promisified readFile benchmark (Nitzan Uziely) #37608 * improve fsPromises readFile performance (Nitzan Uziely) #37608 * lib: * implement AbortSignal.abort() (James M Snell) #37693 * node-api: * define version 8 (Gabriel Schulhof) #37652 * test: * update dom/abort tests (James M Snell) #37693 * fixup test to account for quic openssl version (James M Snell) #37601 * worker: * add setEnvironmentData/getEnvironmentData (James M Snell) #37486

PR-URL: #37766 Notable changes: * crypto: * add optional callback to crypto.sign and crypto.verify (Filip Skokan) #37500 * support JWK objects in create\*Key (Filip Skokan) #37254 * deps: * switch openssl to quictls/openssl (James M Snell) #37601 * fs: * improve fsPromises writeFile performance (Nitzan Uziely) #37610 * improve fsPromises readFile performance (Nitzan Uziely) #37608 * lib: * implement AbortSignal.abort() (James M Snell) #37693 * node-api: * define version 8 (Gabriel Schulhof) #37652 * worker: * add setEnvironmentData/getEnvironmentData (James M Snell) #37486

PR-URL: #37766 Notable changes: * crypto: * add optional callback to crypto.sign and crypto.verify (Filip Skokan) #37500 * support JWK objects in create\*Key (Filip Skokan) #37254 * deps: * update to cjs-module-lexer@1.1.0 (Guy Bedford) #37712 * switch openssl to quictls/openssl (James M Snell) #37601 * fs: * improve fsPromises writeFile performance (Nitzan Uziely) #37610 * improve fsPromises readFile performance (Nitzan Uziely) #37608 * lib: * implement AbortSignal.abort() (James M Snell) #37693 * node-api: * define version 8 (Gabriel Schulhof) #37652 * worker: * add setEnvironmentData/getEnvironmentData (James M Snell) #37486

Refs: whatwg/dom#960 PR-URL: nodejs#37693 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#37693 Refs: whatwg/dom#960 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Refs: whatwg/dom#960 PR-URL: nodejs#37693 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#37693 Refs: whatwg/dom#960 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Refs: whatwg/dom#960 PR-URL: nodejs#37693 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: nodejs#37693 Refs: whatwg/dom#960 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Refs: whatwg/dom#960 PR-URL: #37693 Backport-PR-URL: #38386 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #37693 Backport-PR-URL: #38386 Refs: whatwg/dom#960 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>

Notable changes: * assert: * change status of legacy asserts (James M Snell) (#38113) * doc: * apply style for legacy status (James M Snell) (#37784) * revoke deprecation of legacy url, change status to legacy (James M Snell) (#37784) * add legacy status to stability index (James M Snell) (#37784) * upgrade stability status of report API (Gireesh Punathil) (#35654) * deps: * V8: cherry-pick cf71540c684c (BoHong Li) (#38051) * update ICU to 68.1 (Michaël Zasso) (#36187) * upgrade to libuv 1.41.0 (Colin Ihrig) (#37360) * fs: * add promisified readFile benchmark (Nitzan Uziely) (#37608) * http: * add http.ClientRequest.getRawHeaderNames() (simov) (#37660) * report request start and end with diagnostics\_channel (Stephen Belanger) (#34895) * lib: * create diagnostics\_channel module (Stephen Belanger) (#34895) * implement AbortSignal.abort() (James M Snell) (#37693) * test: * update dom/abort tests (James M Snell) (#37693) * util: * add getSystemErrorMap() impl (eladkeyshawn) (#38101)

PR-URL: #38507 Notable changes: * assert: * change status of legacy asserts (James M Snell) (#38113) * doc: * apply style for legacy status (James M Snell) (#37784) * revoke deprecation of legacy url, change status to legacy (James M Snell) (#37784) * add legacy status to stability index (James M Snell) (#37784) * upgrade stability status of report API (Gireesh Punathil) (#35654) * deps: * V8: cherry-pick cf71540c684c (BoHong Li) (#38051) * update ICU to 68.1 (Michaël Zasso) (#36187) * upgrade to libuv 1.41.0 (Colin Ihrig) (#37360) * fs: * add promisified readFile benchmark (Nitzan Uziely) (#37608) * http: * add http.ClientRequest.getRawHeaderNames() (simov) (#37660) * report request start and end with diagnostics\_channel (Stephen Belanger) (#34895) * lib: * create diagnostics\_channel module (Stephen Belanger) (#34895) * implement AbortSignal.abort() (James M Snell) (#37693) * test: * update dom/abort tests (James M Snell) (#37693) * util: * add getSystemErrorMap() impl (eladkeyshawn) (#38101)

PR-URL: #38507 Notable changes: * assert: * change status of legacy asserts (James M Snell) (#38113) * crypto: * implement randomuuid (James M Snell) (#36729) * doc: * apply style for legacy status (James M Snell) (#37784) * revoke deprecation of legacy url, change status to legacy (James M Snell) (#37784) * add legacy status to stability index (James M Snell) (#37784) * upgrade stability status of report API (Gireesh Punathil) (#35654) * deps: * V8: Backport various patches for Apple Silicon support (BoHong Li) (#38051) * update ICU to 68.1 (Michaël Zasso) (#36187) * upgrade to libuv 1.41.0 (Colin Ihrig) (#37360) * http: * add http.ClientRequest.getRawHeaderNames() (simov) (#37660) * report request start and end with diagnostics\_channel (Stephen Belanger) (#34895) * lib: * create diagnostics\_channel module (Stephen Belanger) (#34895) * implement AbortSignal.abort() (James M Snell) (#37693) * test: * update dom/abort tests (James M Snell) (#37693) * util: * add getSystemErrorMap() impl (eladkeyshawn) (#38101)

PR-URL: #38507 Notable changes: * crypto: * implement randomuuid (James M Snell) (#36729) * doc: * apply style for legacy status (James M Snell) (#37784) * revoke deprecation of legacy url, change status to legacy (James M Snell) (#37784) * add legacy status to stability index (James M Snell) (#37784) * upgrade stability status of report API (Gireesh Punathil) (#35654) * deps: * V8: Backport various patches for Apple Silicon support (BoHong Li) (#38051) * update ICU to 68.1 (Michaël Zasso) (#36187) * upgrade to libuv 1.41.0 (Colin Ihrig) (#37360) * http: * add http.ClientRequest.getRawHeaderNames() (simov) (#37660) * report request start and end with diagnostics\_channel (Stephen Belanger) (#34895) * lib: * create diagnostics\_channel module (Stephen Belanger) (#34895) * implement AbortSignal.abort() (James M Snell) (#37693) * test: * update dom/abort tests (James M Snell) (#37693) * util: * add getSystemErrorMap() impl (eladkeyshawn) (#38101)

nodejs-github-bot added needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels Mar 10, 2021

jasnell mentioned this pull request Mar 10, 2021

Add AbortSignal.aborted() static whatwg/dom#960

Merged

3 tasks

aduh95 added the blocked PRs that are blocked by other issues or PRs. label Mar 10, 2021

aduh95 approved these changes Mar 10, 2021

View reviewed changes

This comment has been minimized.

Sign in to view

lib: implement AbortSignal.abort()

0b60272

Refs: whatwg/dom#960

jasnell force-pushed the implement-abortsignal-abort branch from cfb02a0 to 0b60272 Compare March 11, 2021 15:27

benjamingr reviewed Mar 13, 2021

View reviewed changes

MattiasBuelens mentioned this pull request Mar 15, 2021

lib: add brand checks to AbortController and AbortSignal #37720

Closed

jasnell removed the blocked PRs that are blocked by other issues or PRs. label Mar 15, 2021

jasnell added abortcontroller Issues and PRs related to the AbortController API semver-minor PRs that contain new features and should be released in the next minor version. and removed needs-ci PRs that need a full CI run. labels Mar 15, 2021

test: update dom/abort tests

ce6be51

Signed-off-by: James M Snell <jasnell@gmail.com>

targos approved these changes Mar 15, 2021

View reviewed changes

Ethan-Arrowood approved these changes Mar 15, 2021

View reviewed changes

benjamingr approved these changes Mar 15, 2021

View reviewed changes

jasnell closed this Mar 15, 2021

benjamingr added the notable-change PRs with changes that should be highlighted in changelogs. label Mar 15, 2021

danielleadams mentioned this pull request Mar 16, 2021

v15.12.0 proposal #37766

Merged

hamishwillee mentioned this pull request Mar 29, 2021

Add AbortSignal.abort() static method mdn/browser-compat-data#9648

Merged

targos added the backport-open-v14.x label Apr 24, 2021

targos mentioned this pull request Apr 24, 2021

[v14.x] Backport AbortController and friends #38386

Closed

targos added backported-to-v14.x and removed backport-open-v14.x labels Apr 30, 2021

danielleadams mentioned this pull request May 3, 2021

v14.17.0 proposal #38507

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

lib: implement AbortSignal.abort() #37693

lib: implement AbortSignal.abort() #37693

jasnell commented Mar 10, 2021 •

edited

Loading

This comment has been minimized.

nodejs-github-bot commented Mar 11, 2021 •

edited by jasnell

Loading

benjamingr left a comment

benjamingr Mar 13, 2021

jasnell Mar 15, 2021

benjamingr Mar 15, 2021

jasnell commented Mar 15, 2021

nodejs-github-bot commented Mar 15, 2021

benjamingr left a comment

jasnell commented Mar 15, 2021

benjamingr commented Mar 15, 2021

lib: implement AbortSignal.abort() #37693

lib: implement AbortSignal.abort() #37693

Conversation

jasnell commented Mar 10, 2021 • edited Loading

This comment has been minimized.

nodejs-github-bot commented Mar 11, 2021 • edited by jasnell Loading

benjamingr left a comment

Choose a reason for hiding this comment

benjamingr Mar 13, 2021

Choose a reason for hiding this comment

jasnell Mar 15, 2021

Choose a reason for hiding this comment

benjamingr Mar 15, 2021

Choose a reason for hiding this comment

jasnell commented Mar 15, 2021

nodejs-github-bot commented Mar 15, 2021

benjamingr left a comment

Choose a reason for hiding this comment

jasnell commented Mar 15, 2021

benjamingr commented Mar 15, 2021

jasnell commented Mar 10, 2021 •

edited

Loading

nodejs-github-bot commented Mar 11, 2021 •

edited by jasnell

Loading