Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

node-api: fix crash in finalization #37876

Merged
merged 1 commit into from
Mar 24, 2021
Merged

node-api: fix crash in finalization #37876

merged 1 commit into from
Mar 24, 2021

Conversation

mhdawson
Copy link
Member

Refs: nodejs/node-addon-api#906
Refs: #37616

Fix crash introduced by #37616

Signed-off-by: Michael Dawson mdawson@devrus.com

@nodejs-github-bot nodejs-github-bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels Mar 23, 2021
@mhdawson mhdawson mentioned this pull request Mar 23, 2021
Closed
@mhdawson
Copy link
Member Author

@gabrielschulhof can you take a look to confirm you agree it makes sense.

addaleax
addaleax approved these changes Mar 23, 2021
View reviewed changes
Copy link
Member

@addaleax addaleax left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is it possible to add a regression test for this? This also seems like a V8 bug at first glance to me, maybe it's worth fixing this upstream (as well)?

@mhdawson
Copy link
Member Author

@addaleax adding a regression test case would be good but it may take a bit of work to translate the node-addon-api one to an equivalent I can add to Node.js. Since this "unbreaks" the node-addon-api CI my preference would be to land this to get the CI green and then add the regression test through a follow-on PR. Sound reasonable?

@addaleax
Copy link
Member

@mhdawson Yeah, I don't consider that a blocker.

@Trott Trott mentioned this pull request Mar 24, 2021
Closed
@jasnell
Copy link
Member

jasnell commented Mar 24, 2021

If this ends up fixing the issue we've been having on FreeBSD in #37786, then I'd appreciate if we could Fast track this.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36952/

@jasnell jasnell removed the needs-ci PRs that need a full CI run. label Mar 24, 2021
@Trott
Copy link
Member

Trott commented Mar 24, 2021

Adding a fast-track label as @jasnell proposed it and I endorse it. If anyone objects, please remove the label.

@Trott Trott added the fast-track PRs that do not need to wait for 48 hours to land. label Mar 24, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/36953/

@mhdawson @Trott
node-api: fix crash in finalization
42dc4d1 
Refs: nodejs/node-addon-api#906
Refs: nodejs#37616

Fix crash introduced by nodejs#37616

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: nodejs#37876
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott Trott force-pushed the node-api-finalization branch from c897654 to 42dc4d1 Compare March 24, 2021 23:35
@Trott Trott merged commit 42dc4d1 into nodejs:master Mar 24, 2021
@Trott
Copy link
Member

Trott commented Mar 24, 2021

Landed in 42dc4d1

@mhdawson mhdawson mentioned this pull request Mar 25, 2021
Closed
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Mar 26, 2021
@mhdawson @gabrielschulhof
node-api: fix crash in finalization
fecc3f4 
Refs: nodejs/node-addon-api#906
Refs: nodejs#37616

Fix crash introduced by nodejs#37616

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: nodejs#37876
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
gabrielschulhof pushed a commit to gabrielschulhof/node that referenced this pull request Mar 26, 2021
@mhdawson @gabrielschulhof
node-api: fix crash in finalization
dcc5da6 
Refs: nodejs/node-addon-api#906
Refs: nodejs#37616

Fix crash introduced by nodejs#37616

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: nodejs#37876
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
ruyadorno pushed a commit that referenced this pull request Mar 29, 2021
@mhdawson @ruyadorno
node-api: fix crash in finalization
906eb53 
Refs: nodejs/node-addon-api#906
Refs: #37616

Fix crash introduced by #37616

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #37876
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
ruyadorno pushed a commit that referenced this pull request Mar 30, 2021
@mhdawson @ruyadorno
node-api: fix crash in finalization
3ab223d 
Refs: nodejs/node-addon-api#906
Refs: #37616

Fix crash introduced by #37616

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #37876
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@ruyadorno ruyadorno mentioned this pull request Mar 30, 2021
Merged
targos pushed a commit to gabrielschulhof/node that referenced this pull request Apr 24, 2021
@mhdawson @targos
node-api: fix crash in finalization
180c33d 
Refs: nodejs/node-addon-api#906
Refs: nodejs#37616

Fix crash introduced by nodejs#37616

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: nodejs#37876
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos added backport-open-v14.x and removed backport-open-v14.x fast-track PRs that do not need to wait for 48 hours to land. labels Apr 25, 2021
targos pushed a commit that referenced this pull request Apr 26, 2021
@mhdawson @targos
node-api: fix crash in finalization
8413759 
Refs: nodejs/node-addon-api#906
Refs: #37616

Fix crash introduced by #37616

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #37876
Backport-PR-URL: #37802
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
@legendecas legendecas added the node-api Issues and PRs related to the Node-API. label Mar 27, 2022
@legendecas legendecas mentioned this pull request Mar 27, 2022
Closed
legendecas pushed a commit to legendecas/node that referenced this pull request Mar 29, 2022
@mhdawson @legendecas
node-api: fix crash in finalization
affb8b2 
Refs: nodejs/node-addon-api#906
Refs: nodejs#37616

Fix crash introduced by nodejs#37616

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: nodejs#37876
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Mar 30, 2022
@mhdawson @richardlau
node-api: fix crash in finalization
2aa9ca1 
Refs: nodejs/node-addon-api#906
Refs: #37616

Fix crash introduced by #37616

Signed-off-by: Michael Dawson <mdawson@devrus.com>

PR-URL: #37876
Backport-PR-URL: #42512
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlau richardlau mentioned this pull request Mar 30, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
c++ Issues and PRs that require attention from people who are familiar with C++. node-api Issues and PRs related to the Node-API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@mhdawson @addaleax @jasnell @nodejs-github-bot @Trott @cjihrig @targos @BethGriggs @legendecas