doc: add note to util.isBuffer #3790
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mscdex
added
util
|
LGTM |
|
Of note though, it's just an |
|
Since it's deprecated why still keep the usage description of the old API? Shall we reduce to only the note of "Use |
|
LGTM. The message might be better with the description of the function, above the code example. |
|
If it is deprecated can we use the stability note like in other functions in it? |
|
LGTM |
|
@cjihrig are you saying move the note to the top of the section? |
|
@pmq20 well, it hasn't been removed yet. I think we should keep that part until we actually remove the api |
|
@evanlucas I meant move it from line 418 to line 407. If you think it would be more likely to be noticed. |
|
yea, looking back at it, I think that makes more sense |
evanlucas
force-pushed
the
isbufferdocs
branch
from
6ddf6bb to
8705d4e
Compare
|
Updated. PTAL |
|
LGTM |
Since util.isBuffer is deprecated, we should be explicit that Buffer.isBuffer should be used instead. PR-URL: nodejs#3790 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
force-pushed
the
isbufferdocs
branch
from
8705d4e to
7cb3a54
Compare
|
Landed in 7cb3a54. Thanks! |
|
Ah... The deprecation notice is already there. Sorry about the fuss |
evanlucas
added a commit
that referenced
this pull request
Nov 13, 2015
Since util.isBuffer is deprecated, we should be explicit that Buffer.isBuffer should be used instead. PR-URL: #3790 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
added a commit
that referenced
this pull request
Nov 17, 2015
Since util.isBuffer is deprecated, we should be explicit that Buffer.isBuffer should be used instead. PR-URL: #3790 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
|
landed in v4.x-staging in 3435f87 |
evanlucas
added a commit
that referenced
this pull request
Dec 4, 2015
Since util.isBuffer is deprecated, we should be explicit that Buffer.isBuffer should be used instead. PR-URL: #3790 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Closed
evanlucas
added a commit
that referenced
this pull request
Dec 17, 2015
Since util.isBuffer is deprecated, we should be explicit that Buffer.isBuffer should be used instead. PR-URL: #3790 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
evanlucas
added a commit
that referenced
this pull request
Dec 23, 2015
Since util.isBuffer is deprecated, we should be explicit that Buffer.isBuffer should be used instead. PR-URL: #3790 Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since
util.isBufferis deprecated, we should be explicit thatBuffer.isBuffershould be used instead.