Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

riscv64: Add riscv64 configure #37980

Closed
wants to merge 1 commit into from
Closed

riscv64: Add riscv64 configure #37980

wants to merge 1 commit into from

Conversation

luyahan
Copy link
Contributor

@luyahan luyahan commented Mar 30, 2021 •
edited by aduh95
Loading

v8 had been add riscv64 backend, so i open this
pr to add riscv64 configure.

Fixes: #37856

@nodejs-github-bot nodejs-github-bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. labels Mar 30, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37047/

@luyahan luyahan requested a review from targos March 31, 2021 02:21
@gengjiawen
Copy link
Member

@luyahan Do you have riscv64 machines to verify this ?

@luyahan
Copy link
Contributor Author

luyahan commented Mar 31, 2021

@luyahan Do you have riscv64 machines to verify this ?

Yes i have a Hifive unleashed。And i had run test on it.

@gengjiawen
Copy link
Member

@luyahan Do you have riscv64 machines to verify this ?

Yes i have a Hifive unleashed。And i had run test on it.

To make riscv longterm support, any thought provide machines to our infra https://github.com/nodejs/build ?

@luyahan
Copy link
Contributor Author

luyahan commented Mar 31, 2021

@luyahan Do you have riscv64 machines to verify this ?

Yes i have a Hifive unleashed。And i had run test on it.

To make riscv longterm support, any thought provide machines to our infra https://github.com/nodejs/build ?

Our lab ony have two boards.But we have oredered Hifive unmatched that don't delivered ret.
Can we build node.js on v8 simulator mode？If possible, we can run ricv64 test on x64 machine.

@luyahan
Copy link
Contributor Author

luyahan commented Apr 1, 2021

@luyahan Do you have riscv64 machines to verify this ?

Yes i have a Hifive unleashed。And i had run test on it.

To make riscv longterm support, any thought provide machines to our infra https://github.com/nodejs/build ?

About May, PLCT Lab can get some riscv64 .borads and can donate it to Node.js ci

@luyahan
riscv64: Add riscv64 configure
1f7cb9c 
 v8 had been add riscv64 backend, so i open this
pr to add riscv64 configure.

Refs: nodejs#37856
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 14, 2021 •
edited by targos
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/37446/
V8: https://ci.nodejs.org/job/node-test-commit-v8-linux/3917/

@luyahan luyahan changed the title riscv64: Add riscv64 configure riscv64: Add riscv64 configure Apr 14, 2021
@luyahan
Copy link
Contributor Author

luyahan commented Apr 14, 2021

How to retry Build from tarball / test-tarball-linux (pull_request) ?

@gengjiawen
Copy link
Member

Landed in 1d21a8d

@gengjiawen gengjiawen closed this Apr 14, 2021
gengjiawen pushed a commit that referenced this pull request Apr 14, 2021
@luyahan @gengjiawen
build: add riscv64 configure
1d21a8d 
v8 had been add riscv64 backend, so i open this
pr to add riscv64 configure.

Refs: #37856

PR-URL: #37980
Fixes: #37856
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@gengjiawen
Copy link
Member

How to retry Build from tarball / test-tarball-linux (pull_request) ?

It kinds of flaky as long as Jenkins passed. It's fine.

Thanks for the contribution :)

BethGriggs pushed a commit that referenced this pull request Apr 15, 2021
@luyahan @BethGriggs
build: add riscv64 configure
b634922 
v8 had been add riscv64 backend, so i open this
pr to add riscv64 configure.

Refs: #37856

PR-URL: #37980
Fixes: #37856
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Apr 16, 2021
Merged
algitbot pushed a commit to alpinelinux/aports that referenced this pull request Jun 14, 2021
@clandmeter
community/nodejs-current: disable on riscv64
3d42265 
Although riscv64 should be supported it fails to build, disable for now.

../deps/v8/src/codegen/riscv64/macro-assembler-riscv64.h:222:8: error: 'void v8::internal::TurboAssembler::JumpCodeObject(v8::internal::Register)' marked 'override', but does not override
  222 |   void JumpCodeObject(Register code_object) override;

nodejs/node#37980
@qjivy qjivy mentioned this pull request Dec 1, 2021
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@richardlau richardlau richardlau approved these changes

@gengjiawen gengjiawen gengjiawen approved these changes

@targos targos targos approved these changes

Assignees
No one assigned
Labels
build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add riscv64 backend for node.js
5 participants
@luyahan @nodejs-github-bot @gengjiawen @targos @richardlau