Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: remove dead code #38016

Closed
wants to merge 1 commit into from
Closed

test: remove dead code #38016

wants to merge 1 commit into from

Conversation

lpinca
Copy link
Member

@lpinca lpinca commented Apr 1, 2021

console.trace() was used when printing the warning for a possible
event listeners leak. It is no longer used since commit c6656db that
introduced the process.emitWarning() API and used it to print the
warning.

`console.trace()` was used when printing the warning for a possible
event listeners leak. It is no longer used since commit c6656db that
introduced the `process.emitWarning()` API and used it to print the
warning.
@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 1, 2021
@nodejs-github-bot
Copy link
Collaborator

@marsonya marsonya added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 6, 2021
@nodejs-github-bot
Copy link
Collaborator

lpinca added a commit that referenced this pull request Apr 6, 2021

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
`console.trace()` was used when printing the warning for a possible
event listeners leak. It is no longer used since commit c6656db that
introduced the `process.emitWarning()` API and used it to print the
warning.

PR-URL: #38016
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@lpinca
Copy link
Member Author

lpinca commented Apr 6, 2021

Landed in d61977f.

@lpinca lpinca closed this Apr 6, 2021
@lpinca lpinca deleted the remove/dead-code branch April 6, 2021 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants