Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib: remove redundant branch in async_hooks #38078

Closed
Closed
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
lib: remove redundant branch in async_hooks
The if-else is check if e.stack is string
according to Node.js docs, e.stack is always
a string, so there is no need for this check

Refs: #38077
  • Loading branch information
PhakornKiong committed Apr 4, 2021
commit a2d0979ffbdaee5cd6fc2c9a8aa958821a6716d8
11 changes: 2 additions & 9 deletions lib/internal/async_hooks.js
Original file line number Diff line number Diff line change
@@ -4,7 +4,7 @@ const {
ArrayPrototypePop,
ArrayPrototypeSlice,
ArrayPrototypeUnshift,
ErrorCaptureStackTrace,

FunctionPrototypeBind,
ObjectPrototypeHasOwnProperty,
ObjectDefineProperty,
@@ -158,14 +158,7 @@ function executionAsyncResource() {

// Used to fatally abort the process if a callback throws.
function fatalError(e) {
if (typeof e.stack === 'string') {
process._rawDebug(e.stack);
} else {
const o = { message: e };
ErrorCaptureStackTrace(o, fatalError);
process._rawDebug(o.stack);
}

process._rawDebug(e.stack);
const { getOptionValue } = require('internal/options');
if (getOptionValue('--abort-on-uncaught-exception')) {
process.abort();