Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

tools: relax max-len lint rule for template strings #38097

Merged
merged 1 commit into from
Apr 7, 2021
Merged

tools: relax max-len lint rule for template strings #38097

merged 1 commit into from
Apr 7, 2021

Conversation

Trott
Copy link
Member

@Trott Trott commented Apr 5, 2021

Splitting template strings across multiple lines can make them harder to
read.

@nodejs-github-bot nodejs-github-bot added lib / src Issues and PRs related to general changes in the lib or src directory. needs-ci PRs that need a full CI run. labels Apr 5, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label Apr 6, 2021
jasnell
jasnell approved these changes Apr 6, 2021
View reviewed changes
Copy link
Member

@jasnell jasnell left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Reluctant +1 .... I dislike both the long lines and having to split the template literals to wrap them.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented Apr 6, 2021 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/37203/ 💚

@jasnell
Copy link
Member

jasnell commented Apr 6, 2021

There's really no reason to make this wait the full 48 hours. Please 👍🏻 to fast-track

@jasnell jasnell added fast-track PRs that do not need to wait for 48 hours to land. and removed needs-ci PRs that need a full CI run. labels Apr 6, 2021
@Trott
tools: relax max-len lint rule for template strings
038608d 
Splitting template strings across multiple lines can make them harder to
read.

PR-URL: nodejs#38097
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@Trott Trott merged commit 038608d into nodejs:master Apr 7, 2021
@Trott
Copy link
Member Author

Trott commented Apr 7, 2021

Landed in 038608d

@Trott Trott deleted the max-len-loosen branch April 7, 2021 11:18
@BethGriggs BethGriggs mentioned this pull request Apr 12, 2021
Merged
targos pushed a commit that referenced this pull request Sep 4, 2021
@Trott @targos
tools: relax max-len lint rule for template strings
d86d37b 
Splitting template strings across multiple lines can make them harder to
read.

PR-URL: #38097
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Reviewed-By: Ruben Bridgewater <ruben@bridgewater.de>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Darshan Sen <raisinten@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Sep 4, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@RaisinTen RaisinTen RaisinTen approved these changes

@marsonya marsonya marsonya approved these changes

@aduh95 aduh95 aduh95 approved these changes

@BridgeAR BridgeAR BridgeAR approved these changes

@cjihrig cjihrig cjihrig approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. fast-track PRs that do not need to wait for 48 hours to land. lib / src Issues and PRs related to general changes in the lib or src directory.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
9 participants
@Trott @nodejs-github-bot @jasnell @cjihrig @BridgeAR @aduh95 @marsonya @RaisinTen @targos