Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade npm to 7.9.0 #38156

Closed
wants to merge 1 commit into from
Closed

deps: upgrade npm to 7.9.0 #38156

wants to merge 1 commit into from

Conversation

ruyadorno
Copy link
Member

FEATURES

DEPENDENCIES

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels Apr 8, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37307/

@ruyadorno ruyadorno added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 8, 2021
@ruyadorno
Copy link
Member Author

fast-track ?

MylesBorins
MylesBorins approved these changes Apr 8, 2021
View reviewed changes
Copy link
Contributor

@MylesBorins MylesBorins left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

RSLGTM

Trott
Trott approved these changes Apr 9, 2021
View reviewed changes
Copy link
Member

@Trott Trott left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM

@Trott
Copy link
Member

Trott commented Apr 9, 2021

Landed in c748668

@Trott Trott closed this Apr 9, 2021
Trott pushed a commit to Trott/io.js that referenced this pull request Apr 9, 2021
@ruyadorno @Trott
deps: upgrade npm to 7.9.0
c748668 
PR-URL: nodejs#38156
Reviewed-By: Myles Borins <myles.borins@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Apr 12, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cjihrig cjihrig cjihrig approved these changes

@Trott Trott Trott approved these changes

@MylesBorins MylesBorins MylesBorins approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@ruyadorno @nodejs-github-bot @Trott @MylesBorins @cjihrig @richardlau