lib: add JSDoc typings for assert #38188
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added JSDoc typings for the assert lib.
nodejs-github-bot
added
assert
Fixed the typo `of` -> `is` of the `ifError()` method's JSDoc description.
bmeck
reviewed
Apr 11, 2021
bmeck
reviewed
Apr 11, 2021
void -> never. Co-authored-by: Bradley Farias <bradley.meck@gmail.com>
Change `Function` -> `() => any`. Co-authored-by: Bradley Farias <bradley.meck@gmail.com>
bmeck
approved these changes
Apr 12, 2021
Improved function types by making it indicate what the function's value should be in the parameters.
targos
reviewed
Apr 13, 2021
Some of the functions returned a promise instead of straight up `void`, `void` -> `Promise<void>`.
Done for checks.
|
Why does the CI even fail |
targos
approved these changes
Apr 15, 2021
|
Landed in 82d5988 |
targos
pushed a commit
that referenced
this pull request
Apr 15, 2021
PR-URL: #38188 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
PR-URL: #38188 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
May 8, 2021
PR-URL: #38188 Reviewed-By: Bradley Farias <bradley.meck@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added JSDoc typings for the assert lib.