-
Notifications
You must be signed in to change notification settings - Fork 30k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
bootstrap: freeze more intrinsics #38217
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
These exist on primordials
:
node/lib/internal/per_context/primordials.js
Lines 214 to 219 in 13c931a
{ name: 'ArrayIterator', original: { | |
prototype: Reflect.getPrototypeOf(Array.prototype[Symbol.iterator]()), | |
} }, | |
{ name: 'StringIterator', original: { | |
prototype: Reflect.getPrototypeOf(String.prototype[Symbol.iterator]()), | |
} }, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You forgot to add these to the const { ... } = primordials
block.
Thanks for the reminder, I didn't forget, I'm waiting for #38215 to land before putting work into this :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for filling these in!
PR-URL: nodejs#38217 Reviewed-By: Guy Bedford <guybedford@gmail.com>
Landed in 7264dbd |
PR-URL: #38217 Reviewed-By: Guy Bedford <guybedford@gmail.com>
Several intrinsics were missing, and the comments were referencing an outdated version of ECMAScript spec.
Blockedon#37263,#38211, and#38215.