Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

test: fix typo in gtest-all.cc #38224

Merged
merged 1 commit into from
Apr 13, 2021
Merged

test: fix typo in gtest-all.cc #38224

merged 1 commit into from
Apr 13, 2021

Conversation

eltociear
Copy link
Contributor

separater -> separator

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels Apr 13, 2021
@targos
Copy link
Member

targos commented Apr 13, 2021

👍 to fast-track

@targos targos added the fast-track PRs that do not need to wait for 48 hours to land. label Apr 13, 2021
@aduh95 aduh95 removed the needs-ci PRs that need a full CI run. label Apr 13, 2021
@eltociear @aduh95
test: fix typo in gtest-all.cc
9498e97 
separater -> separator

PR-URL: nodejs#38224
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@aduh95
Copy link
Contributor

aduh95 commented Apr 13, 2021

Landed in 9498e97

@aduh95 aduh95 merged commit 9498e97 into nodejs:master Apr 13, 2021
BethGriggs pushed a commit that referenced this pull request Apr 15, 2021
@eltociear @BethGriggs
test: fix typo in gtest-all.cc
313661c 
separater -> separator

PR-URL: #38224
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@BethGriggs BethGriggs mentioned this pull request Apr 16, 2021
Merged
targos pushed a commit that referenced this pull request May 1, 2021
@eltociear @targos
test: fix typo in gtest-all.cc
95c7dab 
separater -> separator

PR-URL: #38224
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
@danielleadams danielleadams mentioned this pull request May 3, 2021
Merged
danielleadams pushed a commit that referenced this pull request May 8, 2021
@eltociear @danielleadams
test: fix typo in gtest-all.cc
850dbc5 
separater -> separator

PR-URL: #38224
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@targos targos targos approved these changes

@aduh95 aduh95 aduh95 approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@eltociear @targos @aduh95 @Trott @nodejs-github-bot