test: fixup failing test/internet/test-dns.js #38241
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
needs-ci
addaleax
approved these changes
Apr 14, 2021
richardlau
approved these changes
Apr 14, 2021
jasnell
added
author ready
This comment has been minimized.
This comment has been minimized.
marsonya
approved these changes
Apr 15, 2021
ycjcl868
approved these changes
Apr 15, 2021
|
CI broken |
|
CI is green, there's no reason to make this wait the full 48 hours. Please 👍🏻 to fast-track |
RaisinTen
approved these changes
Apr 15, 2021
There was a problem hiding this comment.
@jasnell Should we update this comment here as well:
- // Try to set an invalid TTL (valid ttl is > 0 and < 256)
+ // Try to set an invalid TTL (valid ttl is >= 0 and < 256)
There's the known failing Build from tarball action. Our collaborator guide says
You could argue the failing test is nothing to do with this PR, but if collaborators are free to ignore failing CI we might as well not bother running them. |
|
Ugh... I missed that failing github ci bit...extremely frustrating. |
VoltrexKeyva
approved these changes
Apr 15, 2021
The `ttl` for the `nodejs.org` DNS record is returning `0` currently. The test checks for `> 0`, causing the test to fail. Signed-off-by: James M Snell <jasnell@gmail.com>
jasnell
force-pushed
the
fixup-internet-test-dns
branch
from
0d92399 to
312ad3a
Compare
lpinca
approved these changes
Apr 16, 2021
|
Landed in 5e588c1 |
jasnell
added a commit
that referenced
this pull request
Apr 17, 2021
The `ttl` for the `nodejs.org` DNS record is returning `0` currently. The test checks for `> 0`, causing the test to fail. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #38241 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
targos
pushed a commit
that referenced
this pull request
May 1, 2021
The `ttl` for the `nodejs.org` DNS record is returning `0` currently. The test checks for `> 0`, causing the test to fail. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #38241 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
May 8, 2021
The `ttl` for the `nodejs.org` DNS record is returning `0` currently. The test checks for `> 0`, causing the test to fail. Signed-off-by: James M Snell <jasnell@gmail.com> PR-URL: #38241 Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
ttlfor thenodejs.orgDNS record is returning0currently. The test checks for> 0, causing the test to fail.Signed-off-by: James M Snell jasnell@gmail.com