Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

typings: add JSDoc typings for readline #38253

Closed
wants to merge 1 commit into from
Closed

typings: add JSDoc typings for readline #38253

wants to merge 1 commit into from

Conversation

VoltrexKeyva
Copy link
Member

Added JSDoc typings for the readline lib module.

@nodejs-github-bot nodejs-github-bot added needs-ci PRs that need a full CI run. readline Issues and PRs related to the built-in readline module. labels Apr 15, 2021
@targos targos added the typings label Apr 16, 2021
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37516/

targos
targos reviewed Apr 16, 2021
View reviewed changes
lib/readline.js Outdated Show resolved Hide resolved
marsonya
marsonya reviewed Apr 19, 2021
View reviewed changes
lib/readline.js Outdated Show resolved Hide resolved
Trott
Trott previously requested changes Apr 24, 2021
View reviewed changes
lib/readline.js Outdated Show resolved Hide resolved
Trott
Trott reviewed Apr 24, 2021
View reviewed changes
lib/readline.js Outdated Show resolved Hide resolved
Trott
Trott reviewed Apr 27, 2021
View reviewed changes
lib/readline.js Show resolved Hide resolved
@Trott Trott dismissed their stale review April 27, 2021 20:11

comments addressed

Trott
Trott reviewed May 1, 2021
View reviewed changes
lib/readline.js Show resolved Hide resolved
Trott
Trott approved these changes May 1, 2021
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with or without the startup performance comments restored.

@VoltrexKeyva @Trott
typings: add JSDoc typings for readline
e192a16 
Added JSDoc typings for the `readline` lib module.
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 2, 2021 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/37882/ 💚

@jasnell jasnell added author ready PRs that have at least one approval, no pending requests for changes, and a CI started. and removed needs-ci PRs that need a full CI run. labels May 4, 2021
@jasnell
Copy link
Member

jasnell commented May 4, 2021

Landed in 46d83b3

@jasnell jasnell closed this May 4, 2021
jasnell pushed a commit that referenced this pull request May 4, 2021
@VoltrexKeyva @jasnell
typings: add JSDoc typings for readline
46d83b3 
Added JSDoc typings for the `readline` lib module.

PR-URL: #38253
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@VoltrexKeyva VoltrexKeyva deleted the patch-3 branch May 4, 2021 21:56
targos pushed a commit that referenced this pull request May 17, 2021
@VoltrexKeyva @targos
typings: add JSDoc typings for readline
c0f0c9a 
Added JSDoc typings for the `readline` lib module.

PR-URL: #38253
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request May 18, 2021
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@targos targos targos left review comments

@jasnell jasnell jasnell approved these changes

@Trott Trott Trott approved these changes

@marsonya marsonya marsonya approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. readline Issues and PRs related to the built-in readline module. typings
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@VoltrexKeyva @nodejs-github-bot @jasnell @Trott @targos @marsonya