Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

build: sync generation of v8_build_config.json #38263

Merged
merged 1 commit into from
Apr 18, 2021
Merged

Commits on Apr 18, 2021

  1. build: sync generation of v8_build_config.json

    The contents of the `v8_build_config.json` file generated when
    configured with `--enable-d8` is missing entries which prevent V8's
    test runner from using the built `d8` binary. Sync the keys written
    into the file with those generated in V8's `deps/v8/BUILD.gn` file.
    
    PR-URL: nodejs#38263
    Reviewed-By: Michaël Zasso <targos@protonmail.com>
    Reviewed-By: James M Snell <jasnell@gmail.com>
    Reviewed-By: Rich Trott <rtrott@gmail.com>
    richardlau committed Apr 18, 2021
    Configuration menu
    Copy the full SHA
    049b703 View commit details
    Browse the repository at this point in the history