tools: skip macOS GitHub Actions test on doc-only changes #38296
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nodejs-github-bot
added
the
meta
richardlau
approved these changes
Apr 19, 2021
aduh95
approved these changes
Apr 19, 2021
|
Fast-track? Seems straightforward, low-risk, potentially high-reward, and easy to revert. |
targos
approved these changes
Apr 19, 2021
Trott
added
the
author ready
benjamingr
approved these changes
Apr 19, 2021
RaisinTen
approved these changes
Apr 19, 2021
Trott
added a commit
to Trott/io.js
that referenced
this pull request
Apr 19, 2021
We skip macOS GitHub Actions pushes on doc-only changes but the intention was no doubt to skip them on pull requests too. We still run the tests on Linux, so addons tests will still run when addons docs change. PR-URL: nodejs#38296 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
|
Landed in d4f33f1 |
targos
pushed a commit
that referenced
this pull request
May 1, 2021
We skip macOS GitHub Actions pushes on doc-only changes but the intention was no doubt to skip them on pull requests too. We still run the tests on Linux, so addons tests will still run when addons docs change. PR-URL: #38296 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
May 8, 2021
We skip macOS GitHub Actions pushes on doc-only changes but the intention was no doubt to skip them on pull requests too. We still run the tests on Linux, so addons tests will still run when addons docs change. PR-URL: #38296 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Michaël Zasso <targos@protonmail.com> Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We skip macOS GitHub Actions pushes on doc-only changes but the
intention was no doubt to skip them on pull requests too. We still run
the tests on Linux, so addons tests will still run when addons docs
change.