Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: disable LTO for "v8_cppgc_shared" target #38346

Closed
wants to merge 1 commit into from
Closed

tools: disable LTO for "v8_cppgc_shared" target #38346

wants to merge 1 commit into from

Commits on Apr 22, 2021

  1. tools: disable LTO for "v8_cppgc_shared" target

    "PushAllRegistersAndIterateStack" is implemented in assembly and
    called from "stack.cc" via 'extern "C"'. [1]
    
    However, LTO does not work well with symbol usage from assembly. [2]
    
    This change workarounds the issue by disabling LTO for the target.
    
    With GCC 10 and "./configure --enable-lto", compilation succeeds
    after this change.
    
    [1] v8/v8@c10863153
    [2] https://gcc.gnu.org/wiki/LinkTimeOptimizationFAQ#Symbol_usage_from_assembly_language
    
    Refs: #35957
    Refs: #38335
    Signed-off-by: Jesse Chan <jc@linux.com>
    jesec committed Apr 22, 2021
    Configuration menu
    Copy the full SHA
    ea694e2 View commit details
    Browse the repository at this point in the history