Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

lib,zlib: fix brotli flush range #38408

Merged
merged 1 commit into from
May 1, 2021
Merged

lib,zlib: fix brotli flush range #38408

merged 1 commit into from
May 1, 2021

Conversation

XadillaX
Copy link
Contributor

@XadillaX XadillaX commented Apr 26, 2021 •
edited
Loading

Fixes: #38407

@github-actions github-actions bot added needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib subsystem. labels Apr 26, 2021
@XadillaX XadillaX linked an issue Apr 26, 2021 that may be closed by this pull request
zlib.brotliCompressSync results in no response #38407
Closed
addaleax
addaleax reviewed Apr 26, 2021
View reviewed changes
lib/zlib.js Outdated Show resolved Hide resolved
@addaleax addaleax added the brotli Issues and PRs related to the brotli dependency. label Apr 26, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@joyeecheung joyeecheung removed their request for review April 28, 2021 17:34
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37783/

@XadillaX @Trott
zlib: fix brotli flush range
9c7aa96 
Fixes: nodejs#38407

PR-URL: nodejs#38408
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@Trott
Copy link
Member

Trott commented May 1, 2021

Landed in 9c7aa96

@Trott Trott merged commit 9c7aa96 into nodejs:master May 1, 2021
targos pushed a commit that referenced this pull request May 3, 2021
@XadillaX @targos
zlib: fix brotli flush range
67bd0ec 
Fixes: #38407

PR-URL: #38408
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request May 3, 2021
Merged
targos pushed a commit that referenced this pull request May 30, 2021
@XadillaX @targos
zlib: fix brotli flush range
ebfde56 
Fixes: #38407

PR-URL: #38408
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@XadillaX @targos
zlib: fix brotli flush range
bdc3210 
Fixes: #38407

PR-URL: #38408
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@XadillaX @targos
zlib: fix brotli flush range
ba5ece7 
Fixes: #38407

PR-URL: #38408
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@XadillaX @targos
zlib: fix brotli flush range
8702b04 
Fixes: #38407

PR-URL: #38408
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Zijian Liu <lxxyxzj@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Lxxyx Lxxyx Lxxyx approved these changes

@addaleax addaleax addaleax approved these changes

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
brotli Issues and PRs related to the brotli dependency. needs-ci PRs that need a full CI run. zlib Issues and PRs related to the zlib subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

zlib.brotliCompressSync results in no response
6 participants
@XadillaX @nodejs-github-bot @Trott @jasnell @addaleax @Lxxyx