Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

doc: add try/catch in http2 respondWithFile example #38410

Closed
wants to merge 1 commit into from
Closed

doc: add try/catch in http2 respondWithFile example #38410

wants to merge 1 commit into from

Conversation

mcollina
Copy link
Member

No description provided.

@mcollina mcollina requested review from jasnell and ronag April 26, 2021 12:52
@github-actions github-actions bot added doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem. labels Apr 26, 2021
benjamingr
benjamingr approved these changes Apr 26, 2021
View reviewed changes
Copy link
Member

@benjamingr benjamingr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM (After you fix the missing semicolon)

benjamingr
benjamingr reviewed Apr 26, 2021
View reviewed changes
doc/api/http2.md Outdated Show resolved Hide resolved
@mcollina
Copy link
Member Author

mcollina commented Apr 26, 2021 •
edited by jasnell
Loading

CI-lite: https://ci.nodejs.org/job/node-test-pull-request-lite-pipeline/4218/ 💚

@jasnell
Copy link
Member

jasnell commented Apr 28, 2021

Landed in 1adcae9

@jasnell jasnell closed this Apr 28, 2021
jasnell pushed a commit that referenced this pull request Apr 28, 2021
@mcollina @jasnell
doc: add try/catch in http2 respondWithFile example
1adcae9 
PR-URL: #38410
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Apr 29, 2021
@mcollina @targos
doc: add try/catch in http2 respondWithFile example
f197012 
PR-URL: #38410
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request May 3, 2021
Merged
targos pushed a commit that referenced this pull request May 30, 2021
@mcollina @targos
doc: add try/catch in http2 respondWithFile example
087bae9 
PR-URL: #38410
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@mcollina @targos
doc: add try/catch in http2 respondWithFile example
134f57c 
PR-URL: #38410
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
targos pushed a commit that referenced this pull request Jun 5, 2021
@mcollina @targos
doc: add try/catch in http2 respondWithFile example
f9f5685 
PR-URL: #38410
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request Jun 6, 2021
Merged
targos pushed a commit that referenced this pull request Jun 11, 2021
@mcollina @targos
doc: add try/catch in http2 respondWithFile example
945450b 
PR-URL: #38410
Reviewed-By: Benjamin Gruenbaum <benjamingr@gmail.com>
Reviewed-By: Gerhard Stöbich <deb2001-github@yahoo.de>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjamingr benjamingr benjamingr approved these changes

@Flarna Flarna Flarna approved these changes

@jasnell jasnell jasnell approved these changes

@ronag ronag Awaiting requested review from ronag

Assignees
No one assigned
Labels
doc Issues and PRs related to the documentations. http2 Issues or PRs related to the http2 subsystem.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mcollina @jasnell @benjamingr @Flarna