Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debugger: enable linter on internal/inspector/inspect_client #38417

Merged
merged 1 commit into from
May 3, 2021
Merged

debugger: enable linter on internal/inspector/inspect_client #38417

merged 1 commit into from
May 3, 2021

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented Apr 26, 2021

No description provided.

@github-actions github-actions bot added inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run. labels Apr 26, 2021
@aduh95 aduh95 requested a review from Trott April 28, 2021 14:10
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37790/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37798/

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37806/

Trott
Trott approved these changes May 2, 2021
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI is green

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/37870/

@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 2, 2021
@aduh95
debugger: enable linter on internal/inspector/inspect_client
2c0fd32 
PR-URL: nodejs#38417
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@aduh95 aduh95 force-pushed the inspect_client-linter branch from baf3192 to 2c0fd32 Compare May 3, 2021 11:57
@aduh95
Copy link
Contributor Author

aduh95 commented May 3, 2021

Landed in 2c0fd32

@aduh95 aduh95 merged commit 2c0fd32 into nodejs:master May 3, 2021
@aduh95 aduh95 deleted the inspect_client-linter branch May 3, 2021 11:58
targos pushed a commit that referenced this pull request May 3, 2021
@aduh95 @targos
debugger: enable linter on internal/inspector/inspect_client
0e446d6 
PR-URL: #38417
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@targos targos mentioned this pull request May 3, 2021
Merged
aduh95 added a commit to aduh95/node that referenced this pull request Jul 19, 2021
@aduh95
debugger: enable linter on internal/inspector/inspect_client
26fb6b9 
PR-URL: nodejs#38417
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@richardlau richardlau mentioned this pull request Jul 19, 2021
Closed
@richardlau
Copy link
Member

Backport to v14.x PR: #39446

aduh95 added a commit to aduh95/node that referenced this pull request Jul 20, 2021
@aduh95
debugger: enable linter on internal/inspector/inspect_client
0cc9815 
PR-URL: nodejs#38417
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
aduh95 added a commit to aduh95/node that referenced this pull request Jul 20, 2021
@aduh95
debugger: enable linter on internal/inspector/inspect_client
9b960d9 
PR-URL: nodejs#38417
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
@aduh95 @richardlau
debugger: enable linter on internal/inspector/inspect_client
752282a 
PR-URL: #38417
Backport-PR-URL: #39446
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
@aduh95 @richardlau
debugger: enable linter on internal/inspector/inspect_client
e58f938 
PR-URL: #38417
Backport-PR-URL: #39446
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
@richardlau richardlau mentioned this pull request Jul 22, 2021
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@aduh95 @foxxyz
debugger: enable linter on internal/inspector/inspect_client
9b0d4a1 
PR-URL: nodejs#38417
Backport-PR-URL: nodejs#39446
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Rich Trott <rtrott@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@aduh95 @nodejs-github-bot @richardlau @jasnell @Trott @targos