quictls/openssl 3.0.0-alpha-15 tests

[danbev]

This pull request contains to commits related to updating to quictls/openssl 3.0.0-alpha-15.

Fixes: #38373

[danbev]

@richardlau This should enable us to dynamically link with quictls/openssl 3.0.0-alpha-15. I've tested this locally and I'm able to get all the tests to pass and hopefully this will enable us to update the CI job.

[richardlau]

@danbev With this PR I'm down to one failure when testing locally with openssl3.0.0-alpha15+quic, benchmark/test-benchmark-crypto:

=== release test-benchmark-crypto ===
Path: benchmark/test-benchmark-crypto
--- stderr ---
node:internal/crypto/keys:637
    handle.init(kKeyTypePrivate, data, format, type, passphrase);
           ^

Error: error:068000A8:asn1 encoding routines::wrong tag
    at Object.createPrivateKey (node:internal/crypto/keys:637:12)
    at getKeyObject (/home/iojs/node/benchmark/crypto/oneshot-sign-verify.js:22:24)
    at Array.map (<anonymous>)
    at main (/home/iojs/node/benchmark/crypto/oneshot-sign-verify.js:109:23)
    at /home/iojs/node/benchmark/common.js:42:9
    at processTicksAndRejections (node:internal/process/task_queues:78:11) {
  opensslErrorStack: [
    'error:0688010A:asn1 encoding routines::nested asn1 error',
    'error:0688010A:asn1 encoding routines::nested asn1 error'
  ],
  library: 'asn1 encoding routines',
  reason: 'wrong tag',
  code: 'ERR_OSSL_ASN1_WRONG_TAG'
}
node:assert:123
  throw new AssertionError(obj);
  ^

AssertionError [ERR_ASSERTION]: Expected values to be strictly equal:

1 !== 0

    at ChildProcess.<anonymous> (/home/iojs/node/test/common/benchmark.js:30:12)
    at ChildProcess.emit (node:events:365:28)
    at Process.ChildProcess._handle.onexit (node:internal/child_process:290:12) {
  generatedMessage: true,
  code: 'ERR_ASSERTION',
  actual: 1,
  expected: 0,
  operator: 'strictEqual'
}
Command: out/Release/node /home/iojs/node/test/benchmark/test-benchmark-crypto.js

[danbev]

With this PR I'm down to one failure when testing locally with openssl3.0.0-alpha15+quic, benchmark/test-benchmark-crypto:

Ah sorry about that, I only ran the test target. I'll run test-benchmark and update the test.

[richardlau]

Tests are all passing now. Thanks.

[richardlau]

@danbev any reason for this to remain in draft?

[danbev]

@danbev any reason for this to remain in draft?

Not really, I was only concerned about it breaking until we upgrade to alpha-15 but I'll change it now.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/37827/

[richardlau]

@danbev any reason for this to remain in draft?

Not really, I was only concerned about it breaking until we upgrade to alpha-15 but I'll change it now.

Ah didn't realise this breaks on openssl 3.0.0-alpha14 😞. This will need some coordination to not break all the other open PRs.

[Trott]

That's a lot of skipped tests. Is the idea that when it's out of alpha, they won't be skipped anymore?

[danbev]

That's a lot of skipped tests. Is the idea that when it's out of alpha, they won't be skipped anymore?

We should be able to enable these again once #15067 is in a new release which will hopefully be in the next alpha (or beta) release of OpenSSL.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/37927/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/37932/

[richardlau]

Does anyone know how to get the actions to run? Do we need to force push to this PR to trigger them?

[danbev]

Does anyone know how to get the actions to run?

I'm not sure but I'll rebase this now and that should run them.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/37939/

[richardlau]

Thanks. As previously mentioned this PR needs to be coordinated with nodejs/build#2644 as it makes the tests break on openssl 3.0.0-alpha14+quic (currently used on the CI). My plan is to get CI runs on this PR that are passing except for the openssl300 build (expected to fail) and then update the build containers and resume (which should result in the openssl300 build passing) before landing.

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/37942/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/37944/

[nodejs-github-bot]

CI: https://ci.nodejs.org/job/node-test-pull-request/37948/

[richardlau]

Landed in aed17e9...2ff93c8.