Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

debugger: refactor inspect_repl to use primordials #38551

Closed
wants to merge 3 commits into from
Closed

debugger: refactor inspect_repl to use primordials #38551

wants to merge 3 commits into from
+316 −251

Conversation

aduh95
Copy link
Contributor

@aduh95 aduh95 commented May 5, 2021 •
edited
Loading

No description provided.

@github-actions github-actions bot added inspector Issues and PRs related to the V8 inspector protocol needs-ci PRs that need a full CI run. labels May 5, 2021
@aduh95 aduh95 marked this pull request as ready for review May 7, 2021 09:49
@aduh95 aduh95 force-pushed the inspector-primordials branch from 8fd8135 to db42730 Compare May 7, 2021 09:49
@aduh95 aduh95 requested a review from Trott May 7, 2021 14:17
Trott
Trott approved these changes May 8, 2021
View reviewed changes
Copy link
Member

@Trott Trott left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rubber-stamp LGTM if CI is green.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@aduh95 aduh95 added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 9, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@jasnell jasnell removed the needs-ci PRs that need a full CI run. label May 10, 2021
@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 10, 2021 •
edited by jasnell
Loading

CI: https://ci.nodejs.org/job/node-test-pull-request/38006/ 💚

@jasnell
Copy link
Member

jasnell commented May 14, 2021

Landed in 284f74d

@jasnell jasnell closed this May 14, 2021
jasnell pushed a commit that referenced this pull request May 14, 2021
@aduh95 @jasnell
debugger: refactor inspect_repl to use primordials
284f74d 
PR-URL: #38551
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@aduh95 aduh95 deleted the inspector-primordials branch May 14, 2021 22:56
targos pushed a commit that referenced this pull request May 17, 2021
@aduh95 @targos
debugger: refactor inspect_repl to use primordials
36bb724 
PR-URL: #38551
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@targos targos mentioned this pull request May 18, 2021
Merged
aduh95 added a commit to aduh95/node that referenced this pull request Jul 19, 2021
@aduh95
debugger: refactor inspect_repl to use primordials
4367e45 
PR-URL: nodejs#38551
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 added a commit to aduh95/node that referenced this pull request Jul 20, 2021
@aduh95
debugger: refactor inspect_repl to use primordials
0c7e243 
PR-URL: nodejs#38551
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
aduh95 added a commit to aduh95/node that referenced this pull request Jul 20, 2021
@aduh95
debugger: refactor inspect_repl to use primordials
22320ed 
PR-URL: nodejs#38551
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
@aduh95 @richardlau
debugger: refactor inspect_repl to use primordials
4836cca 
PR-URL: #38551
Backport-PR-URL: #39446
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
richardlau pushed a commit that referenced this pull request Jul 22, 2021
@aduh95 @richardlau
debugger: refactor inspect_repl to use primordials
f9a4dcb 
PR-URL: #38551
Backport-PR-URL: #39446
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
@richardlau richardlau mentioned this pull request Jul 22, 2021
Merged
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
@aduh95 @foxxyz
debugger: refactor inspect_repl to use primordials
c718162 
PR-URL: nodejs#38551
Backport-PR-URL: nodejs#39446
Reviewed-By: Rich Trott <rtrott@gmail.com>
Reviewed-By: James M Snell <jasnell@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Trott Trott Trott approved these changes

@jasnell jasnell jasnell approved these changes

Assignees
No one assigned
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. inspector Issues and PRs related to the V8 inspector protocol
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@aduh95 @nodejs-github-bot @jasnell @Trott @targos