tools: use PrintCaughtException in the snapshot builder #38745
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This prints not only the error message but also the error source line and the stack trace wherever possible.
legendecas
approved these changes
May 20, 2021
| TryCatch bootstrapCatch(isolate); | ||
| v8::MaybeLocal<Value> result = env->RunBootstrapping(); | ||
| if (bootstrapCatch.HasCaught()) { | ||
| PrintCaughtException(isolate, context, bootstrapCatch); |
There was a problem hiding this comment.
Suggested change
| PrintCaughtException(isolate, context, bootstrapCatch); | |
| PrintCaughtException(isolate, context, bootstrapCatch); | |
| abort(); |
There was a problem hiding this comment.
There is already a result.ToLocalChecked(); below which should abort the process if there's an exception
Co-authored-by: Voltrex <62040526+VoltrexMaster@users.noreply.github.com>
addaleax
approved these changes
May 20, 2021
cjihrig
approved these changes
May 21, 2021
JungMinu
approved these changes
May 21, 2021
VoltrexKeyva
approved these changes
May 21, 2021
|
Landed in 308ab8a |
joyeecheung
added a commit
that referenced
this pull request
May 26, 2021
This prints not only the error message but also the error source line and the stack trace wherever possible. PR-URL: #38745 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
danielleadams
pushed a commit
that referenced
this pull request
May 31, 2021
This prints not only the error message but also the error source line and the stack trace wherever possible. PR-URL: #38745 Reviewed-By: Chengzhong Wu <legendecas@gmail.com> Reviewed-By: Anna Henningsen <anna@addaleax.net> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: Minwoo Jung <nodecorelab@gmail.com>
Merged
|
Doesn't land cleanly on v14.x-staging. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This prints not only the error message but also the error
source line and the stack trace wherever possible.