Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

src: use SPrintF in ProcessEmitWarning #38758

Closed

Conversation

RaisinTen
Copy link
Contributor

No description provided.

@github-actions github-actions bot added c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run. labels May 21, 2021
addaleax
addaleax previously approved these changes May 22, 2021
src/node_process.h Outdated Show resolved Hide resolved
@addaleax addaleax dismissed their stale review May 22, 2021 13:52

code changed

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso
@nodejs-github-bot

This comment has been minimized.

@RaisinTen RaisinTen added the author ready PRs that have at least one approval, no pending requests for changes, and a CI started. label May 22, 2021
@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

nodejs-github-bot commented May 24, 2021

@jasnell
Copy link
Member

jasnell commented May 25, 2021

Landed in fa7cdd6

@jasnell jasnell closed this May 25, 2021
jasnell pushed a commit that referenced this pull request May 25, 2021

Verified

This commit was signed with the committer’s verified signature.
BethGriggs Bethany Griggs
PR-URL: #38758
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@RaisinTen RaisinTen deleted the src/use-SPrintF-in-ProcessEmitWarning branch May 25, 2021 14:17
danielleadams pushed a commit that referenced this pull request May 31, 2021

Verified

This commit was signed with the committer’s verified signature.
targos Michaël Zasso
PR-URL: #38758
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
@danielleadams danielleadams mentioned this pull request May 31, 2021
@richardlau
Copy link
Member

Doesn't land cleanly on v14.x-staging.

RaisinTen added a commit to RaisinTen/node that referenced this pull request Jul 17, 2021
PR-URL: nodejs#38758
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
RaisinTen added a commit to RaisinTen/node that referenced this pull request Jul 17, 2021
PR-URL: nodejs#38758
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

Backport-PR-URL: nodejs#39419
@RaisinTen
Copy link
Contributor Author

@richardlau Backport PR: #39419

richardlau pushed a commit to RaisinTen/node that referenced this pull request Jul 19, 2021
PR-URL: nodejs#38758
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

Backport-PR-URL: nodejs#39419
richardlau pushed a commit that referenced this pull request Jul 19, 2021
PR-URL: #38758
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

Backport-PR-URL: #39419
richardlau pushed a commit that referenced this pull request Jul 20, 2021
PR-URL: #38758
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

Backport-PR-URL: #39419
@richardlau richardlau mentioned this pull request Jul 20, 2021
foxxyz pushed a commit to foxxyz/node that referenced this pull request Oct 18, 2021
PR-URL: nodejs#38758
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>

Backport-PR-URL: nodejs#39419
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
author ready PRs that have at least one approval, no pending requests for changes, and a CI started. c++ Issues and PRs that require attention from people who are familiar with C++. needs-ci PRs that need a full CI run.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

7 participants