lib: use primordial for noop #38802
Closed
lib: use primordial for noop #38802
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Most of the internal modules use the `FunctionPrototype` primordial for no-op functions, we could use them here for consistency.
aduh95
requested changes
May 25, 2021
There was a problem hiding this comment.
Based on #38246 (comment), I think we should refrain from doing this. It doesn't change the code behaviour, avoiding re-declaring empty functions may save a few bytes from memory but if it's introducing perf regressions, the trade-off is not worth it IMHO.
Oh I see, yea I think this is probably not worth it; closing. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Most of the internal modules use the
FunctionPrototypeprimordial for no-op functions, we could use them here for consistency.