Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

build: export more OpenSSL symbols on Windows #38857

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

build: export more OpenSSL symbols on Windows #38857

wants to merge 1 commit into from

Conversation

mscdex
Copy link
Contributor

@mscdex mscdex commented May 30, 2021

No description provided.

@mscdex mscdex added the wip Issues and PRs that are still a work in progress. label May 30, 2021
@github-actions github-actions bot added addons Issues and PRs related to native addons. needs-ci PRs that need a full CI run. test Issues and PRs related to the tests. labels May 30, 2021
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot

This comment has been minimized.

Sign in to view
@mscdex mscdex added the build Issues and PRs related to build files or the CI. label May 30, 2021
@mscdex mscdex marked this pull request as ready for review May 30, 2021 17:26
@mscdex mscdex removed the wip Issues and PRs that are still a work in progress. label May 30, 2021
@mscdex
Copy link
Contributor Author

mscdex commented May 30, 2021 •
edited
Loading

Getting a lot of unrelated EACCES failures for parallel/test-fs-rm on multiple platforms.... not sure what that's about.

EDIT: I'm guessing f9447b7 may be the culprit for that

@targos
Copy link
Member

targos commented Jul 11, 2021

@mscdex I think these issues will be fixed if you rebase.

@nodejs-github-bot

This comment has been minimized.

Sign in to view
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/38962/

@mscdex mscdex removed the needs-ci PRs that need a full CI run. label Jul 11, 2021
@targos targos added the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Nov 12, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/47881/

This was referenced Nov 13, 2022
Open
Open
Open
This was referenced Nov 16, 2022
Open
Open
@aduh95
Copy link
Contributor

aduh95 commented May 11, 2024

This needs a rebase

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jasnell jasnell jasnell approved these changes

@addaleax addaleax addaleax approved these changes

@bl-ue bl-ue bl-ue approved these changes

Assignees
No one assigned
Labels
addons Issues and PRs related to native addons. build Issues and PRs related to build files or the CI. test Issues and PRs related to the tests.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
7 participants
@mscdex @nodejs-github-bot @targos @aduh95 @jasnell @addaleax @bl-ue