-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
tools: update gyp-next to v0.9.1 #38867
Conversation
This comment has been minimized.
This comment has been minimized.
By the way, since there's no patches floating on top of gyp-next anymore, should we just make it a git submodule? (also, there is a newer patch version out, maybe you'd like to switch to that version?) |
This comment has been minimized.
This comment has been minimized.
Landed in ffdaf47 |
PR-URL: #38867 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Michaël Zasso <targos@protonmail.com>
We forgot to run V8 CI and it is now broken: https://ci.nodejs.org/job/node-test-commit-v8-linux/4031/nodes=benchmark-ubuntu1604-intel-64,v8test=v8test/console @richardlau Do you think it's possible to make it a hybrid build (use Python 2 for V8 and Python 3 for Node.js) ? |
Yes. #38969 is one possibility. Another would be to not create the ¹FWIW the gyp documentation for actions recommends
|
PR-URL: #38867 Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org> Reviewed-By: Michaël Zasso <targos@protonmail.com>
No description provided.