Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tools: update gyp-next to v0.9.1 #38867

Closed
wants to merge 1 commit into from
Closed

Conversation

gengjiawen
Copy link
Member

No description provided.

@github-actions github-actions bot added build Issues and PRs related to build files or the CI. needs-ci PRs that need a full CI run. tools Issues and PRs related to the tools directory. labels May 31, 2021
@gengjiawen

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

@gengjiawen gengjiawen removed the needs-ci PRs that need a full CI run. label Jun 1, 2021
@ryzokuken
Copy link
Contributor

ryzokuken commented Jun 1, 2021

By the way, since there's no patches floating on top of gyp-next anymore, should we just make it a git submodule?

(also, there is a newer patch version out, maybe you'd like to switch to that version?)

@nodejs-github-bot

This comment has been minimized.

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@nodejs-github-bot
Copy link
Collaborator

@gengjiawen
Copy link
Member Author

Landed in ffdaf47

@gengjiawen gengjiawen closed this Jun 3, 2021
gengjiawen added a commit that referenced this pull request Jun 3, 2021
PR-URL: #38867
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@gengjiawen gengjiawen deleted the bump_gyp branch June 3, 2021 01:55
@targos
Copy link
Member

targos commented Jun 8, 2021

We forgot to run V8 CI and it is now broken: https://ci.nodejs.org/job/node-test-commit-v8-linux/4031/nodes=benchmark-ubuntu1604-intel-64,v8test=v8test/console

@richardlau Do you think it's possible to make it a hybrid build (use Python 2 for V8 and Python 3 for Node.js) ?

@richardlau
Copy link
Member

We forgot to run V8 CI and it is now broken: https://ci.nodejs.org/job/node-test-commit-v8-linux/4031/nodes=benchmark-ubuntu1604-intel-64,v8test=v8test/console

@richardlau Do you think it's possible to make it a hybrid build (use Python 2 for V8 and Python 3 for Node.js) ?

Yes. #38969 is one possibility. Another would be to not create the python override symlink at all and update all gyp actions that call python to call python3¹ but I'd consider that a riskier change.

¹FWIW the gyp documentation for actions recommends

For maximum cross-platform compatibility, invocations that require a Python interpreter should be specified with a first element "python". This will enable generators for environments with specialized Python installations to be able to perform the action in an appropriate Python environment.

targos pushed a commit that referenced this pull request Jun 11, 2021
PR-URL: #38867
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Richard Lau <rlau@redhat.com>
Reviewed-By: Ujjwal Sharma <ryzokuken@disroot.org>
Reviewed-By: Michaël Zasso <targos@protonmail.com>
@danielleadams danielleadams mentioned this pull request Jun 14, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
build Issues and PRs related to build files or the CI. tools Issues and PRs related to the tools directory.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants