-
Notifications
You must be signed in to change notification settings - Fork 29.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
build: dont-land gyp-next PRs on LTS branches #38887
Closed
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gyp-next doesn't support Python 3 anymore so we can't backport its updates.
github-actions
bot
added
the
meta
Issues and PRs related to the general management of the project.
label
Jun 1, 2021
richardlau
approved these changes
Jun 1, 2021
bl-ue
approved these changes
Jun 1, 2021
BethGriggs
approved these changes
Jun 1, 2021
aduh95
added
the
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
label
Jun 1, 2021
lpinca
approved these changes
Jun 1, 2021
jasnell
approved these changes
Jun 1, 2021
gengjiawen
approved these changes
Jun 2, 2021
targos
added a commit
that referenced
this pull request
Jun 3, 2021
gyp-next doesn't support Python 3 anymore so we can't backport its updates. PR-URL: #38887 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Landed in 43cba1d |
targos
added a commit
that referenced
this pull request
Jun 11, 2021
gyp-next doesn't support Python 3 anymore so we can't backport its updates. PR-URL: #38887 Reviewed-By: Richard Lau <rlau@redhat.com> Reviewed-By: Beth Griggs <bgriggs@redhat.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Jiawen Geng <technicalcute@gmail.com>
Merged
For the record this should say "Python 2" |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
author ready
PRs that have at least one approval, no pending requests for changes, and a CI started.
meta
Issues and PRs related to the general management of the project.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
gyp-next doesn't support Python 3 anymore so we can't backport its updates.