net: use missing validator #38984
Closed
net: use missing validator #38984
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The `net` lib module's `lookupAndConnect()` function is missing a validator.
github-actions
bot
added
needs-ci
aduh95
approved these changes
Jun 9, 2021
Lxxyx
approved these changes
Jun 10, 2021
aduh95
added
the
author ready
RaisinTen
approved these changes
Jun 10, 2021
lpinca
approved these changes
Jun 10, 2021
Lxxyx
added
request-ci
github-actions
bot
removed
the
request-ci
cjihrig
approved these changes
Jun 11, 2021
jasnell
reviewed
Jun 11, 2021
jasnell
approved these changes
Jun 11, 2021
Check if the value of `options.lookup` doesn't equal to `undefined`. Co-authored-by: James M Snell <jasnell@gmail.com>
github-actions
bot
removed
the
request-ci
himself65
approved these changes
Jun 12, 2021
|
Landed in 7a0a8ef |
jasnell
pushed a commit
that referenced
this pull request
Jun 14, 2021
The `net` lib module's `lookupAndConnect()` function is missing a validator. PR-URL: #38984 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
danielleadams
pushed a commit
that referenced
this pull request
Jun 15, 2021
The `net` lib module's `lookupAndConnect()` function is missing a validator. PR-URL: #38984 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
Merged
danielleadams
pushed a commit
that referenced
this pull request
Jun 17, 2021
The `net` lib module's `lookupAndConnect()` function is missing a validator. PR-URL: #38984 Reviewed-By: Antoine du Hamel <duhamelantoine1995@gmail.com> Reviewed-By: Zijian Liu <lxxyxzj@gmail.com> Reviewed-By: Darshan Sen <raisinten@gmail.com> Reviewed-By: Luigi Pinca <luigipinca@gmail.com> Reviewed-By: Colin Ihrig <cjihrig@gmail.com> Reviewed-By: James M Snell <jasnell@gmail.com> Reviewed-By: Zeyu Yang <himself65@outlook.com>
|
Backport blocked on v14.x-staging by #37045. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
netlib module'slookupAndConnect()function is missing a validator.