Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: add OS X to module loading error test #3901

Merged
merged 1 commit into from
Nov 18, 2015

Conversation

evanlucas
Copy link
Contributor

Previously, this test was not supported on OS X. This change makes sure
that it is no longer skipped.

@evanlucas evanlucas added the test Issues and PRs related to the tests. label Nov 18, 2015
@evanlucas
Copy link
Contributor Author

@bnoordhuis
Copy link
Member

LGTM

1 similar comment
@Fishrock123
Copy link
Contributor

LGTM

@cjihrig
Copy link
Contributor

cjihrig commented Nov 18, 2015

Previously, this test was not supported on OS X. This change makes sure
that it is no longer skipped.

PR-URL: nodejs#3901
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@evanlucas evanlucas closed this Nov 18, 2015
@evanlucas evanlucas deleted the darwinmod branch November 18, 2015 15:51
@evanlucas evanlucas merged commit 339d384 into nodejs:master Nov 18, 2015
@evanlucas
Copy link
Contributor Author

Thanks! Landed in 339d384

evanlucas added a commit that referenced this pull request Dec 5, 2015
Previously, this test was not supported on OS X. This change makes sure
that it is no longer skipped.

PR-URL: #3901
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@rvagg rvagg mentioned this pull request Dec 17, 2015
evanlucas added a commit that referenced this pull request Dec 29, 2015
Previously, this test was not supported on OS X. This change makes sure
that it is no longer skipped.

PR-URL: #3901
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
MylesBorins pushed a commit that referenced this pull request Jan 19, 2016
Previously, this test was not supported on OS X. This change makes sure
that it is no longer skipped.

PR-URL: #3901
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
@MylesBorins MylesBorins mentioned this pull request Jan 19, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
test Issues and PRs related to the tests.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants